Fix Format function to not cut of last character (fixes game save) #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if it is possible to create a larger test that excercises SaveGame+LoadGame to detect such breakage. |
Jarod42
reviewed
Oct 27, 2024
Currently issue is to create such state. Easier might be using existing savegame, and check that load+save give back same file. |
This fixes broke game save The beginning of a saved game looked like this: 00000000: 6c6f 6361 6c20 6f6c 6443 7265 6174 6555 local oldCreateU 00000010: 6e69 7420 3d20 4372 6561 7465 556e 6974 nit = CreateUnit 00000020: 006c 6f63 616c 206f 6c64 5365 7452 6573 .local oldSetRes 00000030: 6f75 7263 6573 4865 6c64 203d 2053 6574 ourcesHeld = Set 00000040: 5265 736f 7572 6365 7348 656c 6400 6c6f ResourcesHeld.lo The newlines are replaced by null-characters so games could not be loaded again
zzam
force-pushed
the
format-game-save
branch
from
d7a987a to
c861882
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes broke game save
The beginning of a broken saved game looks like this:
The newlines are replaced by null-characters so games could not be loaded again.