Doactionmove war1gus #712
Merged
Doactionmove war1gus #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
war1gus' move animation is of the form
`{"unbreakable begin", "frame 5", "move N", "wait 2", "wait 1", "unbreakable begin", "frame 0", "wait 1"}`;
// ^^^^ Computation here (unbreakable) :/ ^^^^^ and can be break here
(whereas wargus one is
`{"unbreakable begin", "frame 5", "move N1", "wait 2", "frame 4", "move N2", "unbreakable begin", "frame 0", "wait 1"}`)
// ^^^^^ computation here (breakable)
Computation on path (and IX/IY) was done on next (finished) `"wait X"` after reaching the tile (so was done **inside** the `unbreakable` section for war1gus).
Workaround is to do the computation only on new animation cycle.
Alternative:
- Grouping `"wait N1", "wait N2"` into `"wait N1+N2"` would not be enough (but would be fine).
- Compute path on first `"move"` is problematic (for Wait/unreachable).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close Wargus/war1gus#455