Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CColor to be opaque (alpha=255) instead of transparent #612

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Change CColor to be opaque (alpha=255) instead of transparent #612

merged 1 commit into from
Feb 26, 2024

Conversation

Jarod42
Copy link
Member

@Jarod42 Jarod42 commented Feb 25, 2024 •
edited
Loading

Should fix issue #596 with font display

@Jarod42 Jarod42 requested a review from ipochto February 25, 2024 15:18
@ipochto
Copy link
Member

ipochto commented Feb 25, 2024

Still broken (
2024-02-25-184104_2560x1440_scrot
2024-02-25-184112_2560x1440_scrot

@Jarod42
Change CColor to be opaque (alpha=255) instead of transparent (alph…
38c8133 
…a=0) by default.

It should fix issue with `VideoDrawChar` for some config.
@zzam
Copy link
Contributor

zzam commented Feb 26, 2024

Fixes it for me under linux:
with current master f584f2c
wargus-master-bad-font

with color_alpha 38c8133
wargus-color_alpha-good

This makes the menus usable again.

Mission briefing is fine:
wargus-color_alpha-briefing-good

Only the picturestep in the campagin is still broken. It does not show the image:
wargus-color_alpha-picturestep-not-visible

@Jarod42 Jarod42 merged commit 35df666 into master Feb 26, 2024
4 checks passed
@Jarod42 Jarod42 deleted the color_alpha branch February 26, 2024 16:30
@Jarod42
Copy link
Member Author

Jarod42 commented Feb 26, 2024

I suspect some color should have alpha.
Commit as-is currently, would investigate further for other issue.

@ipochto
Copy link
Member

ipochto commented Feb 26, 2024

Fixed for me too.

@Jarod42 Jarod42 mentioned this pull request Mar 1, 2024
Merged
@Jarod42
Copy link
Member Author

Jarod42 commented Mar 1, 2024

@zzam: black screen should be fixed by #616.
submodule update...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipochto ipochto Awaiting requested review from ipochto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jarod42 @ipochto @zzam