Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

War1gus fix #590

Merged
merged 2 commits into from
Dec 10, 2023
Merged

War1gus fix #590

merged 2 commits into from
Dec 10, 2023

Conversation

Jarod42
Copy link
Member

@Jarod42 Jarod42 commented Dec 9, 2023

No description provided.

@Jarod42 Jarod42 merged commit edc1e9a into master Dec 10, 2023
4 checks passed
@Jarod42 Jarod42 deleted the war1gus_fix branch December 10, 2023 13:17
@ipochto
Copy link
Member

ipochto commented Dec 11, 2023

I see the CI tests pass, but somehow on my PC I get this when compiling:

stratagus/src/include/video.h:44:10: fatal error: guichan/sdl/sdlimage.hpp: No such file or directory
[build]    44 | #include <guichan/sdl/sdlimage.hpp>
[build]       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~

@Jarod42
Copy link
Member Author

Jarod42 commented Dec 11, 2023

Have you updated third-party? (no need to launch update.sh ;-) )
Issue with submodules and switching branches is that it need extra flags to also apply to submodules :-/

@ipochto
Copy link
Member

ipochto commented Dec 11, 2023

You're right.
Updated.
Now have this:

[build] stratagus/third-party/guichan/src/sdl/sdlinput.cpp:55:17: error: ‘uint32_t’ in namespace ‘std’ does not name a type; did you mean ‘wint_t’?
[build]    55 |     static std::uint32_t utf8ToUnicode(const char* text)
[build]       |                 ^~~~~~~~
[build]       |                 wint_t
[build] stratagus/third-party/guichan/src/sdl/sdlinput.cpp: In member function ‘virtual void gcn::SDLInput::pushInput(SDL_Event)’:
[build] stratagus/third-party/guichan/src/sdl/sdlinput.cpp:145:31: error: ‘utf8ToUnicode’ was not declared in this scope
[build]   145 |               keyInput.setKey(utf8ToUnicode(event.text.text));
[build]       |                               ^~~~~~~~~~~~~

@Jarod42
Copy link
Member Author

Jarod42 commented Dec 11, 2023

Shit, missing #include <cstdint> on linux ... :-/

Working on it. just include the missing header as local fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants