[macOS] Regression: Black text on main menu in Wargus (Stratagus bug)

[shinra-electric]

This was a tricky one to track down...

When building Wargus recently I noticed the text on the main menu was black. What was odd was that older builds I had archived also had the same issue, whereas they didn't before. However, after a lot of testing I was able to replicate the issue.

#584 /fix/typos 7b2d62e - OK - White/yellow text
#583 /guichan_official_patched_0_4_0 311a684 - Broken build
#588 /mng a1bd75e - Broken build
#589 /palette_typo 4c213cc - Broken build
#592 /guichan_fix fb35843 - Build fix - Black Text

Screenshots:
#584:

#592:

So the issue that causes the black text is somewhere in between those PRs.

But the reason why this was confusing to track down was that after I opened a build with the bug, any working builds would also have black text until I deleted the Stratagus source folder. After deleting it, the older working builds reverted to white text. I assume this is related to this issue with wartool, where the rpath is not working.

[Jarod42]

I updated to last guichan (0.9.0) (with some patches)...
Seems I miss some regressions :-/
Unfortunately, I don't have macOS, and code works locally (on Windows).
I will see if something related to font might be problematic, but unsure to found it :-/

[Jarod42]

guisan (a guichan fork) has similar/worse issue...
So I really bet for a bug in guichan between 0.4.0 (2005 may 11th) and guisan fork (2007 dec 22th).

[zzam]

The same issue happens for me on linux.
I bisected it to (equals #585):

4d7c864520a2185794767f028a92c37c2a3158fc is the first bad commit
commit 4d7c864520a2185794767f028a92c37c2a3158fc
Author: Jarod42 <[email protected]>
Date:   Sun Nov 19 10:57:14 2023 +0100

    Migrate to latest Guichan.

 src/editor/editloop.cpp |   21 +-
 src/include/font.h      |    2 +-
 src/include/movie.h     |   24 +-
 src/include/video.h     |   26 +-
 src/include/widgets.h   |  205 ++++-----
 src/sound/sound.cpp     |    2 +-
 src/tolua/ui.pkg        |   72 ++--
 src/ui/botpanel.cpp     |    9 +-
 src/ui/mouse.cpp        |   10 +-
 src/ui/widgets.cpp      | 1083 ++++++++++++++++++++---------------------------
 src/video/font.cpp      |   20 +-
 src/video/graphic.cpp   |    1 -
 src/video/mng.cpp       |   20 +-
 src/video/movie.cpp     |   68 +--
 src/video/video.cpp     |    4 +-
 third-party             |    2 +-
 16 files changed, 670 insertions(+), 899 deletions(-)

[Jarod42]

Should be fixed by above PR.

[shinra-electric]

Yes, I can confirm it's fixed.

Thanks 👍🏼