Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional units #201

Merged
merged 4 commits into from
Sep 21, 2024
Merged

Add additional units #201

merged 4 commits into from
Sep 21, 2024

Conversation

nnichols
Copy link
Member

Proposed Changes

  • Added
    • brewtility.units.alcohol-content for converting and displaying alcohol content.
    • brewtility.units.bitterness for rendering displayable IBU values.
    • brewtility.units.carbonation for rendering displayable carbonation values.
    • brewtility.units.specific-gravity now supports measurements in degrees plato.
    • brewtility.predicates.options for option map keys shared across predicate namespaces.
  • Changed
    • brewtility.units now supports a :precision option map key for all conversion functions. This key will round the converted value to the specified number of decimal places. Defaults to the precision of the converted value.
    • brewtility.units.color now supports a reverse-lookup for known RGBa values.
    • All functions in brewtility.predicates now support an option map as a second argument to make their arities consistent.
  • Removed
    • ^:const metadata has been removed from conversion maps

Pre-merge Checklist

  • Read and agree to the Contribution Guidelines and Code of Conduct
  • Write new tests for the changed functionality
  • Update CHANGELOG and increment version
  • Update README and relevant documentation

@nnichols nnichols requested a review from a team as a code owner September 21, 2024 19:07
@WallBrewBot WallBrewBot added documentation Improvements or additions to documentation dependencies Updates to application dependency files test code Updates to the application or library test code source code Updates to the application or library source code tooling Repository tools, CI/CD jobs, automated actions clojure Clojure source code clojurescript ClojureScript source code labels Sep 21, 2024
@nnichols nnichols merged commit d976693 into master Sep 21, 2024
19 checks passed
@nnichols nnichols deleted the add-additional-units branch September 21, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clojure Clojure source code clojurescript ClojureScript source code dependencies Updates to application dependency files documentation Improvements or additions to documentation source code Updates to the application or library source code test code Updates to the application or library test code tooling Repository tools, CI/CD jobs, automated actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants