Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: noti-service FCM 푸시알림 환경 구성, Kafka연결, 인가 과정 처리 (#98) #109

Merged
merged 24 commits into from
Jun 22, 2024

Conversation

DDonghyeo
Copy link
Member

@DDonghyeo DDonghyeo commented Jun 19, 2024

☝️Issue Number

🔎 Key Changes

  • @authuser을 통한 인가 과정 처리
  • FCM 토큰 푸시알림 환경 구성
  • Firebase Token 업데이트 API
  • user-serivce Kafka Consumer 수정
  • 데이터 PK : Long id -> String email로 변경

💌 To Reviewers

  • 푸시 알림 전송 규칙 구성
    NotificationRecord를 통해 사용자가 마지막 알림을 받은 시간을 저장해두고,

image
너무 무분별한 푸시알림 전송을 피하기 위해 마지막 알림을 받은 지 3시간 이내일 경우는 메세지를 전송하지 않도록 설정했습니다.

  • 다시 달려보아요 파이팅

@DDonghyeo DDonghyeo added the feat label Jun 19, 2024
@DDonghyeo DDonghyeo requested review from jinho7 and seheonnn June 19, 2024 09:36
@DDonghyeo DDonghyeo self-assigned this Jun 19, 2024
Copy link
Contributor

@seheonnn seheonnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

알림 관련 예외는 throw로 아예 터지기보단 로그 찍는 것이 더 나을 거 같아요~

@DDonghyeo
Copy link
Member Author

알림 관련 예외는 throw로 아예 터지기보단 로그 찍는 것이 더 나을 거 같아요~

수정 완료했습니다 !!
49b2fd3

@DDonghyeo DDonghyeo merged commit 0b59a86 into develop Jun 22, 2024
1 check passed
@DDonghyeo DDonghyeo deleted the feature/#98 branch June 27, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants