Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix/Tweak] Auto shift end and Benches / Авто завершение смены и скамьи #99

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

RedBurningPhoenix
Copy link
Contributor

Описание PR

Don't ask me what's wrong with PEWS

Изменения

🆑 Warete

  • fix: Some benches had to get their rotation back / Скамьи должны были вернуть свой поворот
  • tweak: Automatic shift end is now off / Выключено автоматическое завершение смены

Copy link
Contributor

coderabbitai bot commented Oct 24, 2024

Walkthrough

The pull request modifies the CCVars class in the Content.Shared.CCVar namespace, specifically changing the configuration variable for the emergency shuttle's auto-call time. The default value is updated from 120 minutes to 0 minutes, allowing for immediate activation of the emergency shuttle without any delay. This change affects only the initialization of the EmergencyShuttleAutoCallTime variable, with no other alterations made to the class.

Changes

File Path Change Summary
Content.Shared/CCVar/CCVars.cs Updated EmergencyShuttleAutoCallTime from 120 to 0 minutes, allowing immediate shuttle activation.

Possibly related PRs

Suggested labels

Changes: C#

Suggested reviewers

  • Spatison
  • DVOniksWyvern

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

github-actions bot commented Oct 24, 2024

RSI Diff Bot; head commit faa81d2 merging into 8720a37
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/SimpleStation14/Structures/Furniture/Benches/pews.rsi

State Old New Status
left Modified
right Modified

Edit: diff updated after faa81d2

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Remuchi
Copy link
Collaborator

Remuchi commented Oct 24, 2024

@RedBurningPhoenix резольв конфликтов и можно мержить

YES?
@PuroSlavKing
Copy link
Member

Ура, смены по 12 часов

@Remuchi Remuchi merged commit b5db4fd into WWhiteDreamProject:master Nov 6, 2024
8 checks passed
@RedBurningPhoenix RedBurningPhoenix deleted the SomeFixes branch November 20, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants