-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Ru Loc / Локализация #51
Conversation
WalkthroughThe pull request introduces several modifications to the Russian localization files across various components. Key changes include the simplification of the OOC patron message format in the chat manager, restructuring and renaming of whitelist command messages for consistency, and the addition of new entries related to unknown values and confirmation prompts in the generic localization file. These updates aim to enhance clarity and usability for users interacting with the chat and command functionalities. Changes
Tip New featuresWalkthrough comment now includes:
Notes:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- Resources/Locale/ru-RU/chat/managers/chat-manager.ftl (1 hunks)
- Resources/Locale/ru-RU/connection-messages.ftl (2 hunks)
- Resources/Locale/ru-RU/generic.ftl (1 hunks)
Files skipped from review due to trivial changes (1)
- Resources/Locale/ru-RU/chat/managers/chat-manager.ftl
Additional comments not posted (16)
Resources/Locale/ru-RU/generic.ftl (4)
8-8
: Approved: New entry for unknown title.The translation for
generic-unknown-title
is appropriate and aligns with the intended use.
12-12
: Approved: New entry for hours.The translation for
generic-hours
is correct and fits well within the context.
14-14
: Approved: New entry for playtime title.The translation for
generic-playtime-title
is accurate and clearly conveys the intended meaning.
16-16
: Approved: New entry for confirmation prompt.The translation for
generic-confirm
is straightforward and appropriate for user interactions requiring confirmation.Resources/Locale/ru-RU/connection-messages.ftl (12)
15-15
: Approved: New description for whitelist add command.The description for
cmd-whitelistadd-desc
is clear and accurately describes the command's functionality.
16-16
: Approved: New help message for whitelist add command.The help message for
cmd-whitelistadd-help
is concise and effectively communicates the command syntax.
17-17
: Approved: New message for existing user in whitelist.The message for
cmd-whitelistadd-existing
clearly informs the user that the specified username is already in the whitelist.
18-18
: Approved: New confirmation message for added user to whitelist.The confirmation message for
cmd-whitelistadd-added
is straightforward and provides clear feedback that the user has been added to the whitelist.
19-19
: Approved: New error message for user not found in whitelist add command.The error message for
cmd-whitelistadd-not-found
is clear and necessary for informing the user about the unsuccessful operation.
20-20
: Approved: New argument placeholder for whitelist add command.The argument placeholder for
cmd-whitelistadd-arg-player
is essential for clarity in command syntax and helps prevent user errors.
22-22
: Approved: New description for whitelist remove command.The description for
cmd-whitelistremove-desc
is clear and accurately describes the command's functionality.
23-23
: Approved: New help message for whitelist remove command.The help message for
cmd-whitelistremove-help
is concise and effectively communicates the command syntax.
24-24
: Approved: New message for non-existing user in whitelist remove command.The message for
cmd-whitelistremove-existing
clearly informs the user that the specified username is not in the whitelist.
25-25
: Approved: New confirmation message for removed user from whitelist.The confirmation message for
cmd-whitelistremove-removed
is straightforward and provides clear feedback that the user has been removed from the whitelist.
26-26
: Approved: New error message for user not found in whitelist remove command.The error message for
cmd-whitelistremove-not-found
is clear and necessary for informing the user about the unsuccessful operation.
27-27
: Approved: New argument placeholder for whitelist remove command.The argument placeholder for
cmd-whitelistremove-arg-player
is essential for clarity in command syntax and helps prevent user errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool I guess?
Описание PR
Почистит переводы в папках c z-w. Добавил немного переводов.
Переместил папку prototupes из папки ss14-ru в папку ru-RU.
Снес паку White, ибо переводы от туда нигде не используются и есть аналогичная папка _white
Изменения
🆑 Spatison