Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tweak] МедШкаф #189

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Conversation

islambrosgood
Copy link
Contributor

Обычные очки, медхуд и пиратская повязка на 1 глаз для врачей перенесены из НаноМед Плюс в МедШкаф
В МедШкаф добавлено 4 пояса врача

Описание PR

Описание.


Медиа

Список

https://discord.com/channels/1274951101464051846/1320186254092144683


Изменения

🆑 islambrosgood

  • add: Пояс врача теперь в МедШкаф
  • tweak: Очки, медхуд и повязка из НаноМед переехали в МедШкаф

tweak: glasses, hud and eyepatch from nanomed to medidrobe
Copy link
Contributor

coderabbitai bot commented Dec 23, 2024

Обзор

Walkthrough

Изменения затрагивают конфигурационные файлы инвентаря торговых автоматов для медицинского оборудования. В файле medical.yml три элемента были закомментированы, а в файле medidrobe.yml добавлены новые предметы в начальный инвентарь, включая медицинские очки, HUD-очки и медицинский ремень.

Changes

Файл Изменения
Resources/Prototypes/Catalog/VendingMachines/Inventories/medical.yml Закомментированы элементы:
- ClothingEyesGlasses: 5
- ClothingEyesHudMedical: 2
- ClothingEyesEyepatchHudMedical: 2
Resources/Prototypes/Catalog/VendingMachines/Inventories/medidrobe.yml Добавлены элементы в начальный инвентарь:
- ClothingBeltMedical: 4
- ClothingEyesGlasses: 5
- ClothingEyesHudMedical: 2
- ClothingEyesEyepatchHudMedical: 2

Suggested labels

Changes: YML, Status: Needs Review

Suggested reviewers

  • Spatison

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 82174d3 and 378c178.

📒 Files selected for processing (2)
  • Resources/Prototypes/Catalog/VendingMachines/Inventories/medical.yml (1 hunks)
  • Resources/Prototypes/Catalog/VendingMachines/Inventories/medidrobe.yml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • Resources/Prototypes/Catalog/VendingMachines/Inventories/medical.yml
🔇 Additional comments (1)
Resources/Prototypes/Catalog/VendingMachines/Inventories/medidrobe.yml (1)

25-28: Подтверждаю перенос предметов из NanoMed Plus!

Добавление предметов в МедШкаф соответствует целям PR. Количество каждого предмета логично соответствует существующим паттернам:

  • Медицинские ремни (4) соответствуют стандартному количеству экипировки
  • Обычные очки (5) немного больше, но оправдано частотой использования
  • HUD-очки и повязка (2) соответствуют количеству сезонной экипировки

Давайте проверим, что эти предметы действительно удалены из NanoMed Plus:

✅ Verification successful

Проверка успешно завершена - предметы корректно перенесены!

Подтверждаю, что все предметы (очки, HUD-очки и повязка) были правильно закомментированы в NanoMed Plus (medical.yml) и добавлены в МедШкаф (medidrobe.yml) в соответствующих количествах.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify items were removed from NanoMed Plus inventory
# Expected: These items should be commented out in medical.yml

rg "ClothingEyesGlasses|ClothingEyesHudMedical|ClothingEyesEyepatchHudMedical" Resources/Prototypes/Catalog/VendingMachines/Inventories/medical.yml

Length of output: 247


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Remuchi Remuchi merged commit 2458db8 into WWhiteDreamProject:master Dec 24, 2024
10 of 11 checks passed
dexpth pushed a commit to dexpth/wwdpublic that referenced this pull request Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants