[Tweak] AGhost Action Icons #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ОбзорИзменения включают обновление иконок для действий администратора-призрака в файле Изменения
Предлагаемые метки
Предлагаемые рецензенты
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (6)
📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Resources/Prototypes/Entities/Mobs/Player/admin_ghost.yml (1)
116-117: Изменения выглядят согласованнымиВсе изменения следуют единому шаблону и правильно структурированы. Однако есть несколько предложений по улучшению:
- Комментарии "WWDP-Edit" можно удалить, так как система контроля версий уже отслеживает авторство изменений
- Для улучшения читаемости рекомендуется использовать многострочный YAML синтаксис для компонентов InstantAction
Предлагаемый формат:
- type: InstantAction - icon: { sprite: _White/Interface/Actions, state: solar } # WWDP-Edit - iconOn: _White/Interface/Actions/solar.png # WWDP-Edit + icon: + sprite: _White/Interface/Actions + state: solar + iconOn: _White/Interface/Actions/solar.pngAlso applies to: 129-130, 142-143, 155-156, 168-169, 181-182
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (6)
Resources/Textures/_White/Interface/Actions/cargo.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Actions/communication.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Actions/crew.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Actions/radar.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Actions/records.pngis excluded by!**/*.pngResources/Textures/_White/Interface/Actions/solar.pngis excluded by!**/*.png
📒 Files selected for processing (2)
Resources/Prototypes/Entities/Mobs/Player/admin_ghost.yml(6 hunks)Resources/Textures/_White/Interface/Actions/meta.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- Resources/Textures/_White/Interface/Actions/meta.json
🔇 Additional comments (1)
Resources/Prototypes/Entities/Mobs/Player/admin_ghost.yml (1)
116-117: Проверка наличия новых иконок
Необходимо убедиться, что все новые пути к иконкам существуют в файловой системе.
Also applies to: 129-130, 142-143, 155-156, 168-169, 181-182
✅ Verification successful
Все иконки успешно проверены и существуют
Проверка показала, что все новые иконки присутствуют в директории Resources/Textures/_White/Interface/Actions/:
- solar.png
- communication.png
- radar.png
- cargo.png
- crew.png
- records.png
Изменения корректны и все необходимые файлы находятся в правильном месте.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if all new icon files exist
fd -e png -e rsi "_White/Interface/Actions" | grep -E "solar|communication|radar|cargo|crew|records"
Length of output: 100
Script:
#!/bin/bash
# Let's try searching in Resources directory specifically and check both texture files and RSI directories
cd Resources/Textures && find . -type f -o -type d | grep -i "_White/Interface/Actions"
cd ../
find . -type f -o -type d | grep -i "_White/Interface/Actions"
Length of output: 820
Script:
#!/bin/bash
# Let's also check the entire codebase for any references to these paths
rg -l "_White/Interface/Actions"
Length of output: 90
Script:
#!/bin/bash
# Check for any similar icon paths in the codebase
rg "Interface/Actions" -A 2 -B 2
Length of output: 27033
|
что не так нахуй??? |
|
also linter fail valid. Fix it |
Spatison
approved these changes
Dec 23, 2024
PuroSlavKing
pushed a commit
to PuroSlavKing/skibidi-white
that referenced
this pull request
Dec 24, 2024
* snowballs * nah * reviewe * oops + better offset * a
Spatison
pushed a commit
that referenced
this pull request
Dec 25, 2024
* Снежки (#179) * snowballs * nah * reviewe * oops + better offset * a * migrate * fixiki * namespaces * edit flavors --------- Co-authored-by: csqrb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание PR
Ну типа иконки для акшенов агоста, вместо пустых консолей, я осень старавс, кто-нибудь другой поправит.
Медиа
Список
Изменения