Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tweak] Morgue Sprites #150

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

PuroSlavKing
Copy link
Member

Описание PR

Крутые спрайты морга и крематория, в подарок крутая анимация горения у морга.


Медиа

Список

image


Изменения

Copy link
Contributor

coderabbitai bot commented Dec 11, 2024

Walkthrough

В данном запросе на изменение обновлен файл meta.json для ресурса morgue.rsi. Информация об авторских правах была изменена, чтобы отразить новый источник, заменив ссылку на репозиторий tgstation на репозиторий BlueMoon-Labs/MOLOT-BlueMoon-Station, с добавлением примечания о редактировании пользователем PuroSlavKing. Также добавлено новое свойство delays в состояние crema_active_light, представляющее собой массив массивов с двумя числами с плавающей точкой (0.15 и 0.1), повторяющимися четыре раза. Остальные состояния остались без изменений.

Changes

Файл Изменения
Resources/Textures/Structures/Storage/morgue.rsi/meta.json Обновлены авторские права и добавлено новое свойство delays в состояние crema_active_light.

Suggested reviewers

  • Remuchi

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between ec70681 and 502bd33.

⛔ Files ignored due to path filters (11)
  • Resources/Textures/Structures/Storage/morgue.rsi/crema_active_light.png is excluded by !**/*.png
  • Resources/Textures/Structures/Storage/morgue.rsi/crema_closed.png is excluded by !**/*.png
  • Resources/Textures/Structures/Storage/morgue.rsi/crema_contents_light.png is excluded by !**/*.png
  • Resources/Textures/Structures/Storage/morgue.rsi/crema_open.png is excluded by !**/*.png
  • Resources/Textures/Structures/Storage/morgue.rsi/crema_tray.png is excluded by !**/*.png
  • Resources/Textures/Structures/Storage/morgue.rsi/morgue_closed.png is excluded by !**/*.png
  • Resources/Textures/Structures/Storage/morgue.rsi/morgue_nomob_light.png is excluded by !**/*.png
  • Resources/Textures/Structures/Storage/morgue.rsi/morgue_nosoul_light.png is excluded by !**/*.png
  • Resources/Textures/Structures/Storage/morgue.rsi/morgue_open.png is excluded by !**/*.png
  • Resources/Textures/Structures/Storage/morgue.rsi/morgue_soul_light.png is excluded by !**/*.png
  • Resources/Textures/Structures/Storage/morgue.rsi/morgue_tray.png is excluded by !**/*.png
📒 Files selected for processing (1)
  • Resources/Textures/Structures/Storage/morgue.rsi/meta.json (1 hunks)
🔇 Additional comments (2)
Resources/Textures/Structures/Storage/morgue.rsi/meta.json (2)

13-30: Конфигурация анимации выглядит корректно

Временные интервалы (0.15с и 0.1с) подходят для анимации эффекта горения. Повторение для всех четырех направлений реализовано правильно.


4-4: Проверка источника спрайтов

Необходимо убедиться в корректности указанного источника и соблюдении условий лицензирования.

✅ Verification successful

Источник спрайтов подтвержден

Коммит ee7daac2a2fd407bbed1915145da73454c6bdc59 существует в репозитории BlueMoon-Labs/MOLOT-BlueMoon-Station и содержит обновления спрайтов, включая изменения для морга. Авторство и происхождение корректно указаны в meta.json.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the source commit exists in the BlueMoon repository

# Check if the commit exists
gh api \
  -H "Accept: application/vnd.github+json" \
  repos/BlueMoon-Labs/MOLOT-BlueMoon-Station/commits/ee7daac2a2fd407bbed1915145da73454c6bdc59

Length of output: 26849


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

RSI Diff Bot; head commit 502bd33 merging into ec70681
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/Storage/morgue.rsi

State Old New Status
crema_active_light Modified
crema_closed Modified
crema_contents_light Modified
crema_open Modified
crema_tray Modified
morgue_closed Modified
morgue_nomob_light Modified
morgue_nosoul_light Modified
morgue_open Modified
morgue_soul_light Modified
morgue_tray Modified

@Spatison Spatison merged commit 74256db into WWhiteDreamProject:master Dec 11, 2024
12 checks passed
@PuroSlavKing PuroSlavKing deleted the MorgueSprites branch December 11, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants