Add CVar to disable pow3r parallel processing #124
Conversation
* Add CVar to disable pow3r parallel processing * Cache CVar value * Fix pointyhat * Move all CVar-ing to Content.Server (cherry picked from commit d5019cee96a922f7e0547bc507fdfa1ed9471a39)
WalkthroughThe pull request introduces significant updates across multiple files, primarily focusing on the power management system and airlock entities. The Changes
Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Vaaankas
changed the title
|
RSI Diff Bot; head commit 5bbd6b4 merging into cd020a9 Resources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/science.rsi
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Outside diff range and nitpick comments (14)
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/meta.json (1)
115-128: Consider standardizing animation timing patterns.The
panel_closinganimation uses an inconsistent pattern of delays:
- Start: 0.1s x 2
- Middle: 0.07s x 4
- End: 0.27s
This differs from
panel_openingwhich uses:
- Start: 0.2s
- Middle: 0.07s x 5
- End: 0.2s
Consider standardizing these patterns for more predictable animations.
"delays": [ [ - 0.1, - 0.1, + 0.2, 0.07, 0.07, 0.07, 0.07, - 0.07, - 0.27 + 0.07, + 0.2 ]Resources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/meta.json (1)
26-32: Consider standardizing emergency animation timingsBoth emergency states (
emergency_open_unlitandemergency_unlit) use the same timing pattern[0.4, 0.4]. This is good for consistency, but consider if this timing provides enough visual urgency for emergency situations.Also applies to: 177-183
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/meta.json (2)
1-4: Consider adding more specific modification details in the copyright notice.While the original source is well documented with the commit hash, the modification note "modified by WD team" could be more specific about what changes were made.
- "copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/c6e3401f2e7e1e55c57060cdf956a98ef1fefc24. modified by WD team", + "copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/c6e3401f2e7e1e55c57060cdf956a98ef1fefc24. Adapted for White Dream project with modified sprite paths and timing adjustments.",
9-203: Consider adding documentation and optimizing delay patterns.Two suggestions for improvement:
State Documentation: Consider adding comments to explain the purpose of different states, especially for special cases like "sparks_damaged" vs "sparks_broken".
Delay Pattern Optimization: Several states share identical delay patterns. Consider extracting common patterns to reduce duplication.
Example optimization:
{ + "delay_patterns": { + "door_movement": [0.1, 0.1, 0.07, 0.07, 0.07, 0.2], + "sparks": [0.1, 0.1, 0.1, 0.1, 0.1, 0.1], + "emergency": [0.4, 0.4] + }, "states": [ { "name": "closing", - "delays": [[0.1, 0.1, 0.07, 0.07, 0.07, 0.2]] + "delays": [{"$ref": "#/delay_patterns/door_movement"}] }, // Apply similar changes to other states ] }Note: This suggestion uses JSON Schema $ref syntax. If the RSI format doesn't support references, consider documenting the patterns in comments instead.
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/meta.json (1)
9-203: Consider adding state descriptions for better maintainability.While the state definitions are well-structured, adding descriptions for each state would improve maintainability and make it easier for other developers to understand the purpose of each state.
Example enhancement:
{ "name": "assembly" + "description": "Visual state for airlock assembly phase" }Resources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/meta.json (1)
1-4: Consider restructuring the copyright notice for better clarity.While the copyright information is complete, consider restructuring it for better readability:
"version": 1, "license": "CC-BY-SA-3.0", - "copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/c6e3401f2e7e1e55c57060cdf956a98ef1fefc24. modified by WD team", + "copyright": { + "original": "tgstation (commit: c6e3401f2e7e1e55c57060cdf956a98ef1fefc24)", + "modifications": "WD team" + }Resources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/meta.json (1)
31-43: Consider extracting common animation patterns.Multiple states (
closing,closing_unlit,opening,opening_unlit,panel_closing,panel_opening) share identical delay patterns[0.1, 0.1, 0.07, 0.07, 0.07, 0.2]. Consider defining this as a shared animation configuration to improve maintainability.Also applies to: 44-56, 78-90, 91-103, 104-116, 125-137
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/meta.json (1)
9-215: Consider adding documentation for state purposesWhile most states are self-explanatory, some states like "assembly" and "welded" could benefit from brief descriptions explaining their purpose and usage context.
Consider adding a "descriptions" field to these states, for example:
{ "name": "assembly" + "description": "Displayed during airlock construction/assembly phase" }Content.Server/Power/Pow3r/BatteryRampPegSolver.cs (3)
11-15: LGTM! Consider adding XML documentation.The new parameter and field for controlling parallel processing are well-implemented. Consider adding XML documentation to explain the purpose and impact of the
disableParallelparameter.public sealed class BatteryRampPegSolver : IPowerSolver { private UpdateNetworkJob _networkJob; private bool _disableParallel; + /// <summary> + /// Initializes a new instance of the <see cref="BatteryRampPegSolver"/> class. + /// </summary> + /// <param name="disableParallel">When true, network processing will be executed serially instead of in parallel. + /// This can help resolve power blinking issues in certain scenarios.</param> public BatteryRampPegSolver(bool disableParallel = false) { _disableParallel = disableParallel;
59-62: LGTM! Consider adding performance monitoring.The parallel processing toggle is well-implemented. To help track the impact of this change, consider:
- Adding debug logging when serial processing is used
- Implementing metrics to monitor processing time differences between parallel and serial execution
This would help identify if the serial processing significantly impacts performance in production.
_networkJob.Networks = group; + if (_disableParallel) + { + Logger.Debug("Processing power network serially due to disabled parallel processing"); + using (ProfilingHandle.Begin("SerialPowerProcessing")) + { + parallel.ProcessSerialNow(_networkJob, group.Count); + } + } + else + { + using (ProfilingHandle.Begin("ParallelPowerProcessing")) + { + parallel.ProcessNow(_networkJob, group.Count); + } + } - if (_disableParallel) - parallel.ProcessSerialNow(_networkJob, group.Count); - else - parallel.ProcessNow(_networkJob, group.Count);
Line range hint
11-62: Consider enhancing configuration management.The current implementation is good, but could be enhanced for better operational control:
- Consider making the parallel processing toggle configurable at runtime through a configuration system
- Add telemetry to track when serial processing is triggered and its impact
- Consider implementing an automatic fallback mechanism that switches to serial processing if specific error conditions are detected
This would provide better operational visibility and control without requiring application restarts.
Content.Server/Power/EntitySystems/PowerNetSystem.cs (2)
37-37: Consider adding error handling for configuration retrievalThe initialization looks good, but consider adding error handling for the configuration retrieval to gracefully handle missing or invalid configuration values.
- _solver = new(_cfg.GetCVar(CCVars.DebugPow3rDisableParallel)); + try + { + var disableParallel = _cfg.GetCVar(CCVars.DebugPow3rDisableParallel); + _solver = new(disableParallel); + } + catch (Exception ex) + { + Logger.Error($"Failed to initialize power solver with config: {ex}"); + _solver = new(false); // Fallback to default + }Also applies to: 59-61
Line range hint
1-65: Architectural feedback on the parallel processing solutionThe implementation of a configuration toggle for parallel processing is a good solution for the power blinking issue. However, consider these architectural improvements:
- Add telemetry or metrics to track when parallel processing is disabled, helping to understand usage patterns
- Consider implementing a more granular approach where parallel processing can be disabled for specific power networks rather than globally
- Document the performance implications of disabling parallel processing in the configuration variable's description
Content.Shared/CCVar/CCVars.cs (1)
2622-2624: Documentation could be more detailedThe current documentation is quite brief. Consider expanding it to include:
- The purpose of disabling parallel processing
- The performance implications
- Any known issues or scenarios where this should be toggled
/// <summary> -/// Set to true to disable parallel processing in the pow3r solver. +/// Controls whether parallel processing in the pow3r solver is disabled. +/// When true, the solver will process power networks sequentially which may be slower but can help diagnose +/// race conditions or improve stability if there are issues with parallel processing. +/// Note: This may impact performance on larger power networks. /// </summary>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (279)
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/deny.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/locked.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/welded_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/assembly-fill.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/assembly-glass.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closed-fill.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closed-glass.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closing-fill.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closing-glass.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closing-panel.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/opening-fill.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/opening-glass.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/opening-panel.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/panel_closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/science.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/science.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/science.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/science.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/science.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/science.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/science.rsi/closing_unlit.pngis excluded by!**/*.png
📒 Files selected for processing (21)
Content.Server/Power/EntitySystems/PowerNetSystem.cs(3 hunks)Content.Server/Power/Pow3r/BatteryRampPegSolver.cs(2 hunks)Content.Shared/CCVar/CCVars.cs(1 hunks)Resources/Prototypes/Entities/Structures/Doors/Airlocks/airlocks.yml(17 hunks)Resources/Prototypes/Entities/Structures/Doors/Airlocks/assembly.yml(33 hunks)Resources/Prototypes/Entities/Structures/Doors/Airlocks/base_structureairlocks.yml(2 hunks)Resources/Prototypes/Entities/Structures/Doors/Airlocks/external.yml(2 hunks)Resources/Prototypes/Entities/Structures/Doors/Airlocks/highsec.yml(1 hunks)Resources/Prototypes/Entities/Structures/Doors/Airlocks/shuttle.yml(3 hunks)Resources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/meta.json(1 hunks)Resources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/meta.json(1 hunks)Resources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/meta.json(1 hunks)Resources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/meta.json(1 hunks)Resources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/meta.json(1 hunks)Resources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/meta.json(1 hunks)Resources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/meta.json(1 hunks)Resources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/meta.json(1 hunks)Resources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/meta.json(1 hunks)Resources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/meta.json(1 hunks)Resources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/meta.json(1 hunks)Resources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/meta.json(1 hunks)
✅ Files skipped from review due to trivial changes (7)
- Resources/Prototypes/Entities/Structures/Doors/Airlocks/airlocks.yml
- Resources/Prototypes/Entities/Structures/Doors/Airlocks/assembly.yml
- Resources/Prototypes/Entities/Structures/Doors/Airlocks/external.yml
- Resources/Prototypes/Entities/Structures/Doors/Airlocks/highsec.yml
- Resources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/meta.json
- Resources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/meta.json
- Resources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/meta.json
🔇 Additional comments (31)
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/meta.json (2)
1-8: LGTM! Metadata section is well-defined.
The metadata section properly includes version, license, copyright attribution with commit hash, and standard RSI dimensions.
9-161: Verify completeness of firelock states.
Let's verify that all necessary states for a functional firelock are present and that no critical states are missing.
✅ Verification successful
All firelock states are present and consistent across variants
Comparing the states between all firelock variants in the codebase shows that the Glass firelock contains all the essential states. The only difference is that Standard firelocks have additional frame1-4 states, which are specific to that variant and not required for Glass firelocks.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for common firelock states in other RSI files for comparison
# Find all firelock RSI metadata files
fd -e json -p ".*firelock\.rsi/meta\.json$" | while read -r file; do
echo "=== $file ==="
# Extract and compare state names
jq -r '.states[].name' "$file"
done
Length of output: 2276
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/meta.json (2)
1-186: LGTM! Well-structured metadata file
The JSON structure is well-organized with:
- Clear version and licensing information
- Proper texture size specification
- Comprehensive set of states for different airlock conditions
- Consistent animation state naming
38-49: Review animation timing patterns
The opening and closing animations use a complex timing sequence [0.2, 0.2, 0.1, 0.1, 0.1, 0.3]. While this provides a smooth animation, consider:
- The initial slower movement (0.2s) might feel unresponsive
- The final 0.3s delay might make the animation feel too long
#!/bin/bash
# Description: Check for consistency in animation timings across other airlock variants
# Expected: Similar timing patterns in related files
# Search for other airlock meta.json files and compare their timing patterns
fd 'meta.json' -t f | grep -i 'airlock' | xargs jq -r '.states[] | select(.name == "opening" or .name == "closing") | .delays[][]'Also applies to: 72-83
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/meta.json (2)
5-8: LGTM!
The texture size is properly defined using standard 32x32 dimensions.
1-204: Verify impact on power blinking issue.
While this file primarily contains texture metadata changes, let's verify if these sprite states could affect the power blinking issue mentioned in the PR objectives.
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/meta.json (4)
1-4: LGTM! Proper licensing and attribution.
The metadata section correctly includes version, license information, and a detailed copyright notice with the source commit hash.
5-8: LGTM! Standard sprite dimensions.
The 32x32 pixel size is appropriate for game sprites and follows the RSI format.
9-193: Verify state completeness for all door conditions.
Please ensure all necessary states have their corresponding unlit versions. For example:
weldedstate (line 192) doesn't have an unlit variantdenystate is only present asdeny_unlit
#!/bin/bash
# Description: Check for consistency in state pairs (lit/unlit versions)
# Extract state names and analyze pairs
jq -r '.states[].name' "Resources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/meta.json" | \
awk '
BEGIN { split("", states) }
{
base = $0
sub(/_unlit$/, "", base)
states[base] = states[base] ? states[base] "," $0 : $0
}
END {
print "State analysis:"
for (base in states) {
split(states[base], variants, ",")
if (length(variants) == 1) {
print "- Warning: Potentially missing pair for state: " variants[1]
}
}
}'195-202: Consider reviewing emergency animation timing.
The emergency state uses a slower animation timing (0.4s) compared to other states. While this might be intentional to make emergency states more noticeable, consider:
- Testing if the 0.4s delay provides enough visibility for emergency situations
- Comparing with emergency animation timings in other similar door types for consistency
✅ Verification successful
Emergency animation timing is consistent across door types
Based on the analysis of all door meta.json files, the 0.4s delay for emergency states is consistently used across nearly all door types, with only two exceptions:
- Wide glass doors (2x1 and 3x1) use 1.2s delays for emergency states
- Some doors have null delays for emergency_open_unlit state, which means they don't animate
The 0.4s timing appears to be the standard emergency animation speed across the codebase, making this implementation consistent with other doors.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check emergency animation timing consistency across door types
# Find and analyze emergency animation timings in all door meta.json files
fd -e json -p 'Doors.*meta.json$' | while read -r file; do
echo "Analyzing $file:"
jq -r '.states[] | select(.name | contains("emergency")) | {name: .name, delays: .delays}' "$file"
done
Length of output: 52524
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/meta.json (3)
1-8: LGTM! Proper metadata attribution and sizing.
The metadata section correctly specifies version, license, and copyright information with proper attribution to tgstation. The 32x32 pixel size is appropriate for sprite textures.
33-42: Consider optimizing repeated delay patterns.
Multiple states share identical delay patterns. Consider extracting common patterns to reduce duplication and improve maintainability.
Let's verify the consistency of delay patterns across other airlock metadata files:
Also applies to: 46-55, 80-89, 93-102, 106-115, 127-136
1-204: Verify relationship with power blinking fix.
While this file contains well-structured texture metadata, it's not immediately clear how it relates to fixing the power blinking and debug client crashes mentioned in the PR objectives. Please clarify if this is part of a larger refactoring effort.
Let's check for related changes:
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/meta.json (2)
5-8: LGTM!
The texture dimensions are properly defined following the RSI format.
9-203: Verify state completeness and animation timing consistency.
-
Some states appear to be missing their counterparts:
weldedexists butwelded_unlitis missingemergency_unlitexists butemergencyis missing
-
Animation timing patterns vary between similar actions:
- Door animations (closing/opening) use: [0.1, 0.1, 0.07, 0.07, 0.07, 0.2]
- Spark animations use: [0.1, 0.1, 0.1, 0.1, 0.1, 0.1]
- Emergency animations use: [0.4, 0.4]
Consider standardizing animation timings for similar actions to maintain visual consistency.
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/meta.json (3)
1-8: LGTM! Well-documented metadata section.
The metadata section properly documents the version, license, copyright (with commit reference), and standard sprite dimensions.
32-190: LGTM! Consistent animation timing patterns.
The animation delays are well-structured and consistent:
- Door movement animations (opening/closing): Quick acceleration pattern
- Spark effects: Uniform timing for visual feedback
- Emergency states: Slower, attention-grabbing pattern
1-204: Verify path references after directory restructure.
The file is part of a new "_White" directory structure. We should verify that all references to this texture have been updated accordingly.
#!/bin/bash
# Description: Check for any references to the old path structure
# Look for potential references to the airlock texture that might need updating
# Search for potential references to airlock paths
rg -l 'Structures/Doors/Airlocks/Glass/maint' --type yaml --type json
# Search for potential old path references that might need updating
rg -l 'Airlocks/Glass/maint' --type yaml --type json | grep -v '_White'Resources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/meta.json (2)
1-8: LGTM! Metadata section is well-structured.
The metadata section properly defines version, license, attribution, and dimensions.
164-177: Verify animation timing differences.
Some states have notably different timing patterns:
sparks_damagedincludes an unusual 1.7s delay at the endemergency_unlituses a different pattern of[0.4, 0.4]
Please confirm if these timing differences are intentional and aligned with the game's design.
Also applies to: 194-202
✅ Verification successful
Let me analyze the search results to verify the animation timing patterns across all airlock files.
Let me check the emergency_unlit timing patterns to complete the verification.
Based on the search results, I can now provide a final response:
Animation timing patterns are consistent across airlock types
The timing patterns are standardized across all airlock variants:
sparks_damaged: Consistent pattern of six 0.1s frames followed by a 1.7s frameemergency_unlit: Consistent pattern of [0.4, 0.4] across all airlocks
The timing differences noted in the review comment are actually the standard patterns used throughout the codebase, not anomalies specific to the medical airlock.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for similar animation patterns in other airlock metadata files
fd -e json -e yaml "meta.json" | xargs rg -A 5 "sparks_damaged|emergency_unlit"
Length of output: 91779
Script:
#!/bin/bash
# Get the full sparks_damaged animation sequence for medical airlock to verify the 1.7s delay
rg -A 10 '"name": "sparks_damaged"' Resources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/meta.json
# Also check for any other airlocks with non-standard timing patterns
rg -A 10 '"name": "sparks_damaged"' Resources/Textures/Structures/Doors/Airlocks/ | grep -A 10 "delays"
Length of output: 30068
Script:
#!/bin/bash
# Get unique delay patterns for emergency_unlit across all airlock files
rg -A 5 '"name": "emergency_unlit"' Resources/Textures/Structures/Doors/Airlocks/ | grep -A 3 "delays" | sort -u
Length of output: 14919
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/meta.json (3)
5-8: LGTM!
The sprite size is properly defined using the standard 32x32 pixel format.
1-4: Verify the referenced Paradise SS13 commit
The copyright notice references a specific commit from Paradise SS13. Let's verify its existence and content.
#!/bin/bash
# Description: Verify the referenced Paradise SS13 commit exists and contains the original asset
# Expected result: Commit exists and contains mining airlock assets
# Check if the commit exists in Paradise SS13 repository
gh api \
-H "Accept: application/vnd.github+json" \
repos/ParadiseSS13/Paradise/commits/9312f1fb7dcdf1c195e255a528f31092613fb60d176-189: Review the extended delay in sparks_damaged animation
The sparks_damaged state includes a notably long delay of 1.7 seconds at the end of its animation sequence, while other spark animations use consistent 0.1s delays. Consider if this extended pause is intentional or should be adjusted for consistency.
✅ Verification successful
Extended delay in sparks_damaged animation is consistent across airlock variants
The 1.7s delay at the end of the sparks_damaged animation sequence is intentionally consistent across nearly all airlock variants in the codebase, with only a few exceptions (external airlocks and wide glass airlocks). This appears to be the standard design pattern for damaged airlock spark animations.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for similar animation patterns in other airlock RSI files
# Expected result: Consistent timing patterns across similar states
# Search for other meta.json files in airlock directories
fd -e json -p 'Airlocks.*meta\.json$' | while read -r file; do
echo "Checking $file for sparks_damaged timing..."
jq -r '.states[] | select(.name == "sparks_damaged") | .delays' "$file"
done
Length of output: 39137
Resources/Prototypes/Entities/Structures/Doors/Airlocks/shuttle.yml (2)
Line range hint 32-168: Inconsistent sprite path updates detected
While some entities have been updated to use the "_White/" prefix (AirlockShuttle, AirlockShuttleAssembly, AirlockShuttleSyndicate), others (AirlockGlassShuttle, AirlockGlassShuttleSyndicate) still use the original paths. This inconsistency might cause visual discrepancies or maintenance issues.
Consider updating all sprite paths consistently:
Structures/Doors/Airlocks/Glass/shuttle.rsi→_White/Structures/Doors/Airlocks/Glass/shuttle.rsiStructures/Doors/Airlocks/Glass/shuttle_syndicate.rsi→_White/Structures/Doors/Airlocks/Glass/shuttle_syndicate.rsi
#!/bin/bash
# Description: Find all airlock sprite references to ensure consistency
# Expected: All related sprite paths should either use "_White/" prefix or not
echo "Checking for inconsistent sprite paths..."
rg "sprite:.*Structures/Doors/Airlocks/" --type yaml32-32: Verify the existence of new sprite assets
The sprite paths have been updated to include the "_White/" prefix. Let's ensure these new assets exist to prevent runtime errors.
Also applies to: 121-121, 168-168
✅ Verification successful
The previous output shows that many sprite paths have been updated with "_White/" prefix, but we need to specifically verify the existence of the shuttle-related sprites. Let's check both the asset existence and their references to make a proper assessment.
Sprite assets verified and consistent
The verification shows that all required "_White" prefixed shuttle airlock sprites exist in the correct locations:
Resources/Textures/_White/Structures/Doors/Airlocks/Standard/shuttle.rsi/Resources/Textures/_White/Structures/Doors/Airlocks/Standard/shuttle_syndicate.rsi/Resources/Textures/_White/Structures/Doors/Airlocks/Glass/shuttle.rsi/Resources/Textures/_White/Structures/Doors/Airlocks/Glass/shuttle_syndicate.rsi/
The sprite path changes in the YAML files are properly aligned with these assets.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check if the new sprite assets exist in the repository
# Expected: All files should exist to prevent runtime errors
echo "Checking for sprite assets..."
fd -e rsi "shuttle\.rsi$" -e "shuttle_syndicate\.rsi$" | grep "_White/Structures/Doors/Airlocks/"
Length of output: 12752
Script:
#!/bin/bash
# Let's check for the existence of sprite assets in Resources directory
echo "Checking for sprite assets in Resources..."
fd -t d -e rsi . Resources/ | grep "_White/.*shuttle"
# Also check if there are any references to these assets in other files
echo -e "\nChecking for references to shuttle sprites..."
rg "shuttle\.rsi" -A 1 -B 1 --type yaml Resources/
Length of output: 3973
Resources/Prototypes/Entities/Structures/Doors/Airlocks/base_structureairlocks.yml (3)
Line range hint 173-175: Verify scope of RCD resistance change
This change prevents the airlock from being deconstructed using RCD. While this might be a valid security feature, it appears unrelated to the PR's stated objectives of fixing power blinking and debug client crashes. Consider moving this change to a separate PR focused on security improvements.
#!/bin/bash
# Description: Check for other RCD-related changes that might be affected
rg "RCDDeconstructable" "Resources/Prototypes/Entities/"14-14: Verify sprite path consistency across airlock variants
The sprite path has been updated to use the "_White" prefix. Let's ensure this change is consistent across all airlock variants.
Also, consider standardizing the comment format. Instead of "# WD EDIT", consider using a more descriptive format like "# Modified: Asset path restructuring".
✅ Verification successful
The previous script didn't correctly search for sprite paths. Let me try a more specific search to verify the sprite paths in airlock files.
Sprite path changes are consistent across airlock variants
The search results show that almost all airlock sprite paths have been consistently updated to use the "_White" prefix, with the "WD EDIT" comment. There are only three exceptions that maintain the old path format, and they are intentionally different:
base_assembly.yml:Structures/Doors/Airlocks/Standard/basic.rsiclockwork.yml: Clockwork-themed airlocks- A few shuttle variants in
shuttle.yml
These exceptions appear to be intentional as they represent special cases or legacy components.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for any inconsistent airlock sprite paths
# Look for airlock sprite paths that don't use the _White prefix
rg -l "sprite:\s+Structures/Doors/Airlocks/" "Resources/Prototypes/Entities/Structures/Doors/Airlocks/"
Length of output: 8393
Script:
#!/bin/bash
# Search for sprite definitions in airlock files to check path consistency
rg "sprite:\s+" "Resources/Prototypes/Entities/Structures/Doors/Airlocks/" -A 1
Length of output: 17573
Line range hint 181-193: Verify gameplay impact of laser transparency
The changes include:
- Updated sprite path to use "_White" prefix (consistent with other changes)
- Removed "opaque" from the layer to allow lasers to pass through glass airlocks
The laser behavior change could have significant gameplay implications. Please verify:
- Is this an intentional gameplay change?
- Has this been tested for potential security exploits?
- Does this align with the game's design principles?
Consider documenting this behavior change in the game's design documentation and ensuring it's properly tested in various scenarios.
✅ Verification successful
Let me gather more specific information about laser interactions and glass structures.
Let me check one more aspect to understand the glass and laser interactions better.
Based on the gathered information, I can now provide a final response:
Glass airlock laser transparency change appears consistent with game mechanics
The modification to allow lasers through glass airlocks is consistent with the game's existing mechanics, as evidenced by:
- Regular glass windows use
GlassLayerwithout opaque property - Glass airlocks follow similar collision layer patterns as other glass structures
- The change maintains consistency with the physical properties of glass in the game
The change appears to be an intentional alignment of glass airlock behavior with other glass structures rather than a security concern.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for other glass structures and their laser interaction settings
# Look for similar layer configurations in glass structures
rg -B 5 "GlassAirlockLayer" "Resources/Prototypes/Entities/Structures/"
# Check for any existing laser-related mechanics
rg -l "laser" "Resources/Prototypes/Entities/"
Length of output: 8393
Script:
#!/bin/bash
# Check for laser-related configurations in glass structures and airlocks
rg -B 5 -A 5 "laser" "Resources/Prototypes/Entities/Structures/Doors/Airlocks/"
# Check other glass structures' layer configurations
rg -B 5 -A 5 "opaque" "Resources/Prototypes/Entities/Structures/"
# Look for glass-related collision layers definitions
rg -B 5 "GlassAirlockLayer" "Resources/Prototypes/Physics/"
Length of output: 3859
Script:
#!/bin/bash
# Check for glass-related collision layers in the entire codebase
rg -B 5 -A 5 "GlassLayer" "Resources/"
# Look for other glass structures and their layer configurations
rg -B 5 -A 5 "glass.*layer" "Resources/Prototypes/Entities/Structures/Windows/"
# Check for any laser-related configurations in weapons
rg -B 5 "laser.*through" "Resources/Prototypes/Entities/"
Length of output: 19250
Content.Server/Power/EntitySystems/PowerNetSystem.cs (2)
6-6: LGTM: Clean dependency integration
The new dependencies for configuration management are properly integrated with appropriate null-safety handling.
Also applies to: 10-10, 23-23
30-30: Verify thread-safety of solver reassignment
The solver field is now mutable to support runtime reconfiguration. While the change is necessary, we should verify thread-safety since this system deals with parallel processing.
✅ Verification successful
Let me gather more information about the solver's usage and thread safety.
Based on the gathered information, I can now provide the final response:
Thread-safety concerns are properly addressed
The solver field mutation is thread-safe because:
- It's only modified during initialization and when the debug CVar changes via
DebugPow3rDisableParallelChanged - The solver is instantiated with a parallel processing flag from configuration
- No concurrent access patterns were found in the codebase
- Solver reassignment happens atomically through a simple assignment operation
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for any concurrent access to the solver field
rg -l "parallel" | xargs rg "_solver" -C 2
# Search for any other systems that might access the solver
ast-grep --pattern $'class $_ : EntitySystem {
$$$
$_solver
$$$
}'
Length of output: 978
Script:
#!/bin/bash
# Check how the solver is used in PowerNetSystem
rg -A 10 -B 2 "class PowerNetSystem"
# Look for any parallel processing or threading related code
rg -A 5 "Parallel|Thread|Lock|concurrent|async" Content.Server/Power/EntitySystems/PowerNetSystem.cs
# Check if solver is accessed in any Update/Tick methods
ast-grep --pattern 'Update($$$) {
$$$
$_solver
$$$
}'
ast-grep --pattern 'Tick($$$) {
$$$
$_solver
$$$
}'
Length of output: 2867
Content.Shared/CCVar/CCVars.cs (1)
2626-2627: Consider the default value for parallel processing
The default value is set to true which means parallel processing is disabled by default. This seems unusual for a performance feature unless there are known stability issues.
If this is intended as a temporary fix for the power blinking and debug client crashes mentioned in the PR, consider:
- Adding a comment explaining why parallel processing is disabled by default
- Creating a tracking issue to re-enable it once the underlying issues are fixed
✅ Verification successful
Let me search for more context about this power system and any related issues.
Based on the git history and code context, I can now provide a final response:
Parallel processing disabled due to recent power system stability fixes
The default value of true for disabling parallel processing was intentionally set in PR #28488 (June 2024) as part of stability improvements to the power system. This is a deliberate change to address power blinking and client crashes, not a temporary fix.
The Pow3r system is a critical power network solver that can operate in both parallel and serial modes. The parallel mode was causing stability issues, hence the introduction of this configuration option with parallel processing disabled by default.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check for any related power system issues or discussions
rg -g "!*.{md,txt}" -A 5 "pow3r.*parallel|parallel.*pow3r"
Length of output: 509
Script:
#!/bin/bash
# Search for power system related code and comments
rg -g "!*.{md,txt}" "Pow3r" -A 5
# Look for any recent changes or discussions in git history
git log -p --grep="[Pp]ow3r.*parallel"
Length of output: 19145
| "license": "CC-BY-SA-3.0", | ||
| "copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/c6e3401f2e7e1e55c57060cdf956a98ef1fefc24. modified by WD team", |
There was a problem hiding this comment.
💡 Codebase verification
The tgstation commit reference is invalid
The referenced commit c6e3401f2e7e1e55c57060cdf956a98ef1fefc24 could not be verified in the tgstation repository. However, there are numerous other files in the codebase that properly attribute assets from tgstation, indicating an established practice of using tgstation assets. The copyright notice should be updated with the correct commit hash or removed if the original commit cannot be found.
🔗 Analysis chain
Verify the tgstation commit reference
The copyright notice references a specific tgstation commit. Let's verify its existence and the proper attribution.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify the referenced tgstation commit and check for the original file
# Expected: The commit exists and contains the original file
# Extract commit hash from the copyright notice
COMMIT="c6e3401f2e7e1e55c57060cdf956a98ef1fefc24"
# Verify commit exists in tgstation repository
gh api repos/tgstation/tgstation/commits/$COMMIT --silent || echo "Commit not found"
Length of output: 4888
Script:
#!/bin/bash
# Let's verify if this is a valid commit in a different way and check for similar files
# First, let's look for any other similar copyright notices in RSI files
rg -l "tgstation/tgstation/commit" --type json
# Then let's check if we have any documentation about sprite attribution
fd -t f "README|NOTICE|LICENSE|ATTRIBUTION" -i
Length of output: 75614
| [ | ||
| 0.1, | ||
| 0.1, | ||
| 0.07, | ||
| 0.07, | ||
| 0.07, | ||
| 0.2 | ||
| ] | ||
| ] | ||
| }, | ||
| { | ||
| "name": "panel_closing", | ||
| "delays": [ | ||
| [ | ||
| 0.1, | ||
| 0.1, | ||
| 0.07, | ||
| 0.07, | ||
| 0.07, | ||
| 0.2 | ||
| ] | ||
| ] | ||
| }, | ||
| { | ||
| "name": "panel_open", | ||
| "delays": [ | ||
| [ | ||
| 1 | ||
| ] | ||
| ] | ||
| }, | ||
| { | ||
| "name": "panel_opening", | ||
| "delays": [ | ||
| [ | ||
| 0.1, | ||
| 0.1, | ||
| 0.07, | ||
| 0.07, | ||
| 0.07, | ||
| 0.2 | ||
| ] | ||
| ] | ||
| }, | ||
| { | ||
| "name": "sparks", | ||
| "delays": [ | ||
| [ | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 0.1 | ||
| ] | ||
| ] | ||
| }, | ||
| { | ||
| "name": "sparks_broken", | ||
| "delays": [ | ||
| [ | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 0.1 | ||
| ] | ||
| ] | ||
| }, | ||
| { | ||
| "name": "sparks_damaged", | ||
| "delays": [ | ||
| [ | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 1.7 | ||
| ] | ||
| ] | ||
| }, | ||
| { | ||
| "name": "sparks_open", | ||
| "delays": [ | ||
| [ | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 0.1 | ||
| ] | ||
| ] | ||
| }, | ||
| { | ||
| "name": "welded" | ||
| }, |
There was a problem hiding this comment.
💡 Codebase verification
Missing state emergency_unlit in maint.rsi
Comparing the states in maint.rsi with other airlock RSIs reveals that it's missing the emergency_unlit state that is present in all other standard airlock variants.
emergency_unlitstate is missing fromResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/meta.json
🔗 Analysis chain
Verify completeness of door states.
The states array includes all standard door variations (open, closed, assembly) and their corresponding unlit versions. However, let's verify that no essential states are missing.
The previous script didn't work as expected since it didn't find the actual RSI files. Let me try a different approach to find and compare airlock states.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Compare states with other airlock RSIs to ensure consistency
# Look for other airlock meta.json files and compare their states
# Find all airlock meta.json files
fd -e json -p 'Airlocks.*meta\.json$' | while read -r file; do
echo "=== States in $file ==="
jq -r '.states[].name' "$file" | sort
done
Length of output: 547
Script:
#!/bin/bash
# Find all meta.json files in Airlocks directories
find . -type f -path "*/Airlocks/**/meta.json" | while read -r file; do
echo "=== States in $file ==="
jq -r '.states[].name' "$file" | sort
done
Length of output: 50294
| private void DebugPow3rDisableParallelChanged(bool val) | ||
| { | ||
| _solver = new(val); |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Optimize solver recreation and add error handling
The configuration change handler could benefit from these improvements:
- Add validation to prevent unnecessary solver recreation
- Include error handling for solver creation
- Consider adding logging for debugging purposes
private void DebugPow3rDisableParallelChanged(bool val)
{
- _solver = new(val);
+ try
+ {
+ if (_solver.DisableParallel != val)
+ {
+ Logger.Debug($"Updating power solver parallel processing: {!val}");
+ _solver = new(val);
+ }
+ }
+ catch (Exception ex)
+ {
+ Logger.Error($"Failed to update power solver configuration: {ex}");
+ }
}Committable suggestion skipped: line range outside the PR's diff.
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Outside diff range and nitpick comments (17)
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/meta.json (1)
38-49: Consider standardizing animation timing patternsThe opening and closing animations use uniform 0.2s delays for all frames. Consider if varying the timing could create more natural-looking animations:
- Slower at start/end (easing)
- Faster in the middle
"delays": [ [ - 0.2, - 0.2, - 0.2, - 0.2, - 0.2, - 0.2 + 0.3, // slower start + 0.2, + 0.15, // faster middle + 0.15, + 0.2, + 0.3 // slower end ] ]Also applies to: 90-101
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/meta.json (1)
9-185: Consider adding documentation for animation timing patterns.The animation states are well-structured but could benefit from documentation explaining the timing patterns. Consider adding comments in the following format:
{ "version": 1, "license": "CC-BY-SA-3.0", "copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/c6e3401f2e7e1e55c57060cdf956a98ef1fefc24. modified by WD team", + "animation_patterns": { + "door_operation": [0.2, 0.2, 0.1, 0.1, 0.1, 0.3], + "panel_operation": [0.1, 0.1, 0.07, 0.07, 0.07, 0.2], + "sparks": [0.1, 0.1, 0.1, 0.1, 0.1, 0.1], + "emergency": [0.4, 0.4] + }, "size": { "x": 32, "y": 32 },This documentation would:
- Make it easier to maintain consistent timing across different states
- Help new contributors understand the animation patterns
- Serve as a reference for creating new states
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/meta.json (2)
1-8: LGTM! Consider enhancing the copyright notice.The metadata section is well-structured with appropriate version, license, and size specifications.
Consider adding a date to the copyright notice to better track when the WD team modifications were made:
- "copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/c6e3401f2e7e1e55c57060cdf956a98ef1fefc24. modified by WD team", + "copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/c6e3401f2e7e1e55c57060cdf956a98ef1fefc24. Modified by WD team (2024)",
28-202: Consider documenting animation timing patterns.The animation delays follow consistent patterns:
- Movement animations (closing/opening): 0.61s total
- Spark effects: 0.6s total
- Emergency blink: 0.8s total
Consider adding comments in the file to document these timing patterns:
{ "version": 1, "license": "CC-BY-SA-3.0", "copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/c6e3401f2e7e1e55c57060cdf956a98ef1fefc24. modified by WD team", + "timing_patterns": { + "movement": [0.1, 0.1, 0.07, 0.07, 0.07, 0.2], + "sparks": [0.1, 0.1, 0.1, 0.1, 0.1, 0.1], + "emergency": [0.4, 0.4] + }, "size": {Resources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/meta.json (1)
166-176: Consider reducing the final delay in sparks_damaged state.The 1.7 second delay at the end of the sparks_damaged animation sequence seems unusually long compared to other state transitions. This might lead to a noticeable pause in the animation.
Consider reducing the final delay to maintain consistency with other spark animations:
[ 0.1, 0.1, 0.1, 0.1, 0.1, 0.1, - 1.7 + 0.1 ]Resources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/meta.json (1)
9-203: Consider optimizing state definitions.Several opportunities for improvement:
- States with single 1-second delays (like "open") could be simplified to static states
- Common delay patterns are duplicated across multiple states (e.g., opening/closing sequences)
Consider these optimizations:
- Remove unnecessary delay arrays for static states:
{ "name": "open", - "delays": [ - [ - 1 - ] - ] },
- Consider extracting common delay patterns into shared variables if your RSI format supports it, to reduce duplication and make future timing adjustments easier.
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/meta.json (2)
2-4: Format the commit URL for better readabilityConsider breaking the long commit URL into multiple lines or shortening it to improve readability.
- "copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/c6e3401f2e7e1e55c57060cdf956a98ef1fefc24. modified by WD team", + "copyright": "Taken from tgstation at commit c6e3401 (tgstation/tgstation). Modified by WD team.",
9-202: Consider reorganizing states for better maintainabilityThe states could be better organized by grouping them functionally. Consider reorganizing them into these categories:
- Basic states (assembly, open, closed)
- Animation states (opening, closing)
- Panel states
- Special effects (sparks)
- Emergency states
This would make the file more maintainable and easier to understand.
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/meta.json (1)
1-8: Document specific modifications in copyright notice.The metadata section is well-structured with proper attribution. However, consider documenting the specific modifications made by the WD team for better traceability.
- "copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/c6e3401f2e7e1e55c57060cdf956a98ef1fefc24. modified by WD team", + "copyright": "Taken from tgstation at commit https://github.com/tgstation/tgstation/commit/c6e3401f2e7e1e55c57060cdf956a98ef1fefc24. Modified by WD team: <list specific changes here>",Resources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/meta.json (2)
9-215: Consider reorganizing states and documenting animation timings.The states array could benefit from:
- Grouping related states together (e.g., all "unlit" states, all "panel" states)
- Adding comments to explain the significance of different timing values
- Using constants for commonly repeated delay values (0.1, 0.05, 0.4)
Consider reorganizing the states like this:
"states": [ + // Basic states { "name": "assembly" }, { "name": "closed" }, { "name": "open", "delays": [[1]] }, + // Unlit variants { "name": "closed_unlit" }, { "name": "open_unlit" }, + // Animation states with standard timing (0.1s base) { "name": "opening", "delays": [[0.1, 0.05, 0.05, 0.1, 0.1, 0.1, 0.1]] }, // ... other states ]
30-35: Document the purpose of different animation timings.The file uses several distinct timing patterns:
- Emergency states: 0.4s intervals (lines 30-35)
- Door movement: 0.1s with 0.05s quick movements (lines 88-98)
- Effects (sparks): 0.1s consistent timing (lines 152-161)
Consider adding comments to explain why these specific timings were chosen and what visual effect they achieve.
Also applies to: 88-98, 152-161
Resources/Prototypes/Entities/Structures/Doors/Airlocks/shuttle.yml (1)
32-32: Consider documenting the purpose of "WD EDIT" commentsThe changes are marked with "# WD EDIT" comments. Consider documenting the purpose of these edits in a README or configuration file for better maintainability.
Also applies to: 121-121, 168-168
Content.Server/Power/Pow3r/BatteryRampPegSolver.cs (2)
59-62: Thoughtful solution for power stability issuesThis change provides a configurable way to address potential race conditions in power processing, which could explain both the power blinking and debug client crashes. The implementation maintains the existing batching optimization while allowing for more stable serial processing when needed.
A few considerations:
- The serial processing mode might impact performance on large power networks
- This change provides a good debugging toggle for isolating parallel processing issues
- The batching size (4) is still respected in both modes, which helps maintain some performance optimization
Consider adding telemetry or logging to:
- Track when serial processing is enabled
- Measure and compare performance between modes
- Monitor for correlation between mode switches and stability issues
This data could help determine if parallel processing should be permanently disabled or if there are specific conditions that trigger the issues.
Line range hint
1-365: Consider additional safety measuresWhile the parallel processing toggle effectively addresses the immediate issues, consider these additional safety measures:
- The power management system handles critical infrastructure, so it might benefit from:
- Deadlock detection in serial mode
- Timeout mechanisms for both processing modes
- Monitoring for power state consistency
- The existing assertions and debug checks are preserved, but consider adding:
- Invariant checks for power conservation
- Validation of network state before and after processing
Would you like help implementing any of these safety measures?
Content.Server/Power/EntitySystems/PowerNetSystem.cs (1)
37-37: Consider adding error handling for configuration accessThe initialization looks good, but consider adding error handling for the case where the configuration value is not found or is invalid.
- _solver = new(_cfg.GetCVar(CCVars.DebugPow3rDisableParallel)); + try + { + _solver = new(_cfg.GetCVar(CCVars.DebugPow3rDisableParallel)); + } + catch (Exception ex) + { + Logger.Error($"Failed to initialize solver with config value: {ex}"); + _solver = new(false); // Fall back to default behavior + }Also applies to: 59-61
Content.Shared/CCVar/CCVars.cs (2)
2622-2627: Consider changing the default value tofalseThe current default value of
truemeans parallel processing is disabled by default, which might be counterintuitive. Unless there's a specific reason for disabling it by default (e.g., known stability issues), consider changing it tofalseto maintain performance benefits of parallel processing while allowing operators to disable it when needed.- CVarDef.Create("debug.pow3r_disable_parallel", true, CVar.SERVERONLY); + CVarDef.Create("debug.pow3r_disable_parallel", false, CVar.SERVERONLY);
2623-2625: Enhance the documentation commentThe current documentation could be more descriptive about when and why one might want to disable parallel processing.
- /// <summary> - /// Set to true to disable parallel processing in the pow3r solver. - /// </summary> + /// <summary> + /// Set to true to disable parallel processing in the pow3r solver. + /// This can be useful for debugging power-related issues or when parallel + /// processing causes stability problems on certain hardware configurations. + /// Note: Disabling parallel processing may impact performance. + /// </summary>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (279)
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/deny.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/locked.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/welded_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/assembly-fill.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/assembly-glass.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closed-fill.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closed-glass.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closing-fill.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closing-glass.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closing-panel.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/opening-fill.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/opening-glass.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/opening-panel.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/panel_closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/closing_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/deny_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/emergency_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/emergency_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/opening_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/panel_closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/panel_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/panel_opening.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/sparks.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/sparks_broken.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/sparks_damaged.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/sparks_open.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/welded.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/science.rsi/assembly.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/science.rsi/bolted_open_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/science.rsi/bolted_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/science.rsi/closed.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/science.rsi/closed_unlit.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/science.rsi/closing.pngis excluded by!**/*.pngResources/Textures/_White/Structures/Doors/Airlocks/Glass/science.rsi/closing_unlit.pngis excluded by!**/*.png
📒 Files selected for processing (21)
Content.Server/Power/EntitySystems/PowerNetSystem.cs(3 hunks)Content.Server/Power/Pow3r/BatteryRampPegSolver.cs(2 hunks)Content.Shared/CCVar/CCVars.cs(1 hunks)Resources/Prototypes/Entities/Structures/Doors/Airlocks/airlocks.yml(17 hunks)Resources/Prototypes/Entities/Structures/Doors/Airlocks/assembly.yml(33 hunks)Resources/Prototypes/Entities/Structures/Doors/Airlocks/base_structureairlocks.yml(2 hunks)Resources/Prototypes/Entities/Structures/Doors/Airlocks/external.yml(2 hunks)Resources/Prototypes/Entities/Structures/Doors/Airlocks/highsec.yml(1 hunks)Resources/Prototypes/Entities/Structures/Doors/Airlocks/shuttle.yml(3 hunks)Resources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/meta.json(1 hunks)Resources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/meta.json(1 hunks)Resources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/meta.json(1 hunks)Resources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/meta.json(1 hunks)Resources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/meta.json(1 hunks)Resources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/meta.json(1 hunks)Resources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/meta.json(1 hunks)Resources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/meta.json(1 hunks)Resources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/meta.json(1 hunks)Resources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/meta.json(1 hunks)Resources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/meta.json(1 hunks)Resources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/meta.json(1 hunks)
✅ Files skipped from review due to trivial changes (7)
- Resources/Prototypes/Entities/Structures/Doors/Airlocks/airlocks.yml
- Resources/Prototypes/Entities/Structures/Doors/Airlocks/assembly.yml
- Resources/Prototypes/Entities/Structures/Doors/Airlocks/base_structureairlocks.yml
- Resources/Prototypes/Entities/Structures/Doors/Airlocks/external.yml
- Resources/Prototypes/Entities/Structures/Doors/Airlocks/highsec.yml
- Resources/Textures/_White/Structures/Doors/Airlocks/Glass/centcomm.rsi/meta.json
- Resources/Textures/_White/Structures/Doors/Airlocks/Glass/glass.rsi/meta.json
🔇 Additional comments (27)
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/meta.json (2)
2-4: Verify copyright compliance
The file indicates it's derived from tgstation repository. Ensure that:
- The modifications by the WD team comply with CC-BY-SA-3.0 license terms
- All attribution requirements are met
✅ Verification successful
License and attribution are properly maintained
The search results confirm that:
- The file correctly attributes the source as tgstation repository with the specific commit hash
- Multiple other files in the codebase use the same attribution format and license (CC-BY-SA-3.0)
- The same commit hash is referenced in other related files (firelock.rsi variants)
- The copyright notice properly indicates modifications ("modified by WD team")
The attribution and licensing are consistent with CC-BY-SA-3.0 requirements, which allow modifications as long as attribution is maintained and the same license is used, both of which are satisfied here.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check if the referenced tgstation commit exists and verify the original file
# Test: Verify the referenced commit and compare with original file
curl -s "https://raw.githubusercontent.com/tgstation/tgstation/04e43d8c1d5097fdb697addd4395fb849dd341bd/Resources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/meta.json"
Length of output: 141
Script:
#!/bin/bash
# Let's try a different approach to verify the copyright and license compliance
# 1. Check if there are other similar files with tgstation attribution
rg -g '*.json' -l "tgstation/tgstation"
# 2. Look for license declarations in RSI meta files
rg -g '*.json' -l "CC-BY-SA-3.0"
# 3. Check the specific commit hash mentioned
rg -g '*.json' "04e43d8c1d5097fdb697addd4395fb849dd341bd"
# 4. Look for other firelock related files
fd "firelock.*\.json$"
Length of output: 281943
9-161: Verify state completeness
The states appear comprehensive but verify that all required states are present for proper door functionality. The current states cover:
- Basic states (open, closed)
- Lighting states (_unlit variants)
- Special states (assembly, welded)
- Animation states (opening, closing)
- Panel states
- Emergency states
✅ Verification successful
The previous command had issues with non-RSI JSON files. Let's specifically target RSI files in the Textures directory containing "airlock" and compare their states to ensure completeness.
Let's try a different approach using find to locate airlock RSI files and examine their states for comparison.
Let's first understand the directory structure and available airlock-related files to form a better search strategy.
Let's compare the states between firelock and basic airlock to ensure all necessary states are present. Basic airlock should serve as a good reference point for standard door states.
States verification complete - minor differences are intentional
Comparing the firelock states with the basic airlock states shows that the firelock has all necessary core functionality states, with differences that reflect its specialized nature:
-
Firelock has additional states:
deny(lit version)lockedwelded_open
-
Firelock intentionally omits:
sparksrelated states (not needed for firelocks)- Some states are only present in unlit variants as firelocks don't have lit versions
These differences are appropriate given that firelocks are a specialized type of airlock with different functionality requirements than basic airlocks.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Compare with other airlock state definitions to ensure consistency
# Test: Check states in other airlock meta.json files
fd -e json -x jq '.states[].name' {} \; | sort | uniq -c | sort -nr
Length of output: 220497
Script:
#!/bin/bash
# Search for airlock state definitions in other airlock RSI files to compare states
fd airlock -e rsi -x jq '.states[].name' {} \; 2>/dev/null | sort | uniq -c | sort -nr
Length of output: 79
Script:
#!/bin/bash
# Search for airlock RSI files in the Resources/Textures directory
find Resources/Textures -type f -name "*airlock*.rsi" -exec sh -c '
echo "=== $1 ==="
jq -r ".states[].name" "$1/meta.json" 2>/dev/null
' sh {} \;
Length of output: 159
Script:
#!/bin/bash
# List all files in the airlock texture directories to understand the structure
ls -R Resources/Textures/**/airlock* 2>/dev/null
# Also check parent directory of the file under review
ls -la Resources/Textures/_White/Structures/Doors/Airlocks/Glass/
Length of output: 1388
Script:
#!/bin/bash
# Compare states between firelock.rsi and basic.rsi to verify completeness
echo "=== Firelock States ==="
jq -r '.states[].name' Resources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/meta.json
echo -e "\n=== Basic Airlock States ==="
jq -r '.states[].name' Resources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/meta.json
Length of output: 838
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/meta.json (1)
2-4: Verify license compatibility with project requirements.
The file properly attributes the original source (tgstation) and uses CC-BY-SA-3.0 license.
✅ Verification successful
License is compatible with project requirements
The texture file's CC-BY-SA-3.0 license is explicitly allowed by the project's licensing policy. The README confirms that "most resources are licensed under CC-BY-SA 3.0" and the file properly attributes the original source (tgstation) with the specific commit reference.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify license compatibility across the project
# Check if other texture files use the same license and if project's main license is compatible
# Check other RSI metadata files
echo "Checking other RSI metadata files for license consistency..."
fd -e json -e meta.json . Resources/Textures/_White | xargs grep -l "license"
# Check main license file
echo "Checking project's main license..."
cat LICENSE
Length of output: 9964
Script:
#!/bin/bash
# Let's check for license information in other common locations and check the content of some RSI files
# Check for license files with different names
echo "Checking for license files..."
fd -i license
# Check content of some RSI meta files to compare licenses
echo -e "\nChecking content of some RSI meta files..."
head -n 5 Resources/Textures/_White/Structures/Doors/Airlocks/Glass/external.rsi/meta.json
echo -e "\nComparing with another RSI file..."
head -n 5 Resources/Textures/_White/Structures/Doors/Airlocks/Glass/basic.rsi/meta.json
# Check root directory for any readme that might contain license info
echo -e "\nChecking README files..."
fd -i readme
Length of output: 1881
Script:
#!/bin/bash
# Let's check the content of the main license files and README to understand the project's licensing
echo "Checking main license files content..."
cat LICENSE-AGPLv3.txt | head -n 10
echo -e "\n---\n"
cat LICENSE-MIT.txt | head -n 10
echo -e "\n---\n"
cat README.md | grep -A 5 -i "licens"
Length of output: 2185
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/meta.json (3)
1-8: LGTM! Proper licensing and metadata.
The metadata section is well-structured with appropriate version, licensing, and attribution information. The texture dimensions are standard for this type of asset.
31-202: LGTM! Well-structured animation timings.
The animation timing patterns are consistent and well-thought-out:
- Movement animations use a smooth acceleration pattern
- Spark effects maintain rapid, consistent timing
- Emergency states use appropriate slower flashing
1-204: Verify JSON syntax validity.
While the structure looks correct, let's verify the JSON syntax.
✅ Verification successful
JSON syntax and required RSI metadata fields are valid
The file has been verified to have:
- Valid JSON syntax with no parsing errors
- All required RSI metadata fields: version, license, size, and states
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Validate JSON syntax and check for common RSI metadata requirements
# Validate JSON syntax
jq '.' "Resources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/meta.json" > /dev/null
# Verify required RSI metadata fields
jq -e 'has("version") and has("license") and has("size") and has("states")' "Resources/Textures/_White/Structures/Doors/Airlocks/Glass/atmospherics.rsi/meta.json"
Length of output: 259
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/cargo.rsi/meta.json (2)
1-8: LGTM: Metadata section is well-structured and properly attributed.
The metadata section correctly includes:
- Version number
- License information
- Detailed copyright attribution with commit reference
- Consistent texture dimensions
196-201: Verify emergency animation timing across all airlocks.
The emergency state uses 0.4s intervals which might be too slow for an emergency indicator. Additionally, we should ensure this timing is consistent across all airlock types.
✅ Verification successful
Emergency animation timing is consistent across airlocks
The verification shows that all standard and glass airlocks use a consistent 0.4s timing for emergency animations, with the only exceptions being wide glass airlocks (2x1 and 3x1) which use 1.2s. This longer timing for wide airlocks makes sense given their larger size.
The 0.4s timing appears to be an intentional standard across the codebase and is appropriate for emergency indicators - it's fast enough to be noticeable while not being too distracting.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check emergency animation timing consistency across all airlock meta.json files
# Expected: All emergency states should have the same timing pattern
# Find all airlock meta.json files and check their emergency state delays
fd meta.json -p "Resources/Textures.*Airlocks" --exec jq -c '.states[] | select(.name == "emergency_unlit") | .delays' {} \;
Length of output: 245
Script:
#!/bin/bash
# Let's try a different approach to find airlock meta files
fd meta.json -p "Resources/Textures" --exec sh -c '
if grep -q "Airlocks" <<< "{}"; then
echo "=== {} ==="
jq -c ".states[] | select(.name == \"emergency_unlit\") | .delays" "{}"
fi
'
Length of output: 152567
Script:
#!/bin/bash
# Let's try a simpler approach to find and check airlock meta files
fd meta.json | while read -r file; do
if grep -q "Airlocks" <<< "$file"; then
echo "=== $file ==="
jq -r '.states[] | select(.name == "emergency_unlit") | .delays' "$file"
fi
done
Length of output: 147948
Script:
#!/bin/bash
# Try a simpler approach using find and grep
find . -path "*/Airlocks/*" -name "meta.json" -exec sh -c '
echo "=== $1 ==="
jq -r ".states[] | select(.name == \"emergency_unlit\") | .delays" "$1"
' sh {} \;
Length of output: 10114
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/command.rsi/meta.json (3)
1-8: LGTM! Metadata section is well-structured.
The metadata section properly defines version, license, copyright attribution, and sprite dimensions.
164-177: Verify the long delay in sparks_damaged animation.
The sparks_damaged state has an unusually long final delay of 1.7 seconds. This might create a noticeable pause in the animation cycle. Consider if this is intentional or should be adjusted to match other spark animations.
✅ Verification successful
The 1.7s delay in sparks_damaged animation is consistent across the codebase
The search results show that this timing pattern is deliberately used across nearly all airlock variants in the codebase. Out of 60+ instances found, the vast majority use the exact same pattern [0.1, 0.1, 0.1, 0.1, 0.1, 0.1, 1.7], with only a few using a shorter variant [0.1, 0.1, 0.1, 0.1, 0.1, 1.7]. This consistent implementation suggests the longer pause is an intentional design choice for the damaged sparks animation cycle.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for other spark animation patterns in RSI metadata files
fd -e json -x grep -l "sparks_damaged" {} \; | xargs cat | jq '.states[] | select(.name == "sparks_damaged")'
Length of output: 9844
1-204: Verify sprite path integration with power system.
Given that this PR addresses power blinking issues, we should verify that the sprite states properly integrate with the power system's state management.
✅ Verification successful
Let me gather more information about the power-related door state handling.
Let me try a different approach to find power-related door state handling.
Based on the gathered evidence, I can now provide a final response:
Sprite states properly integrated with power system
The verification shows that:
- The airlock sprite states (unlit variants) are correctly defined in the RSI metadata
- These states are properly referenced in
AirlockComponent.cswith corresponding state fields - Airlocks have
ApcPowerReceivercomponent that integrates with the power system - The client-side
AirlockSystem.cshandles power state visualization throughunlitVisiblelogic
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for references to this RSI file in power-related systems
rg -l "Structures/Doors/Airlocks/Glass/command\.rsi" | xargs rg "PowerNetSystem|BatteryRampPegSolver"
# Check for any power-related state handling
rg "closed_unlit|open_unlit|emergency_unlit" --type yaml
Length of output: 2573
Script:
#!/bin/bash
# Search for door-related systems that handle power states
ast-grep --pattern 'class $_ : ISystem {
$$$
UnlitState$$$
}'
# Check for door component definitions that might handle power
rg -A 5 "DoorComponent|AirlockComponent" --type cs
# Look for power-related door state changes
rg "SetState.*unlit|PoweredState" --type cs
Length of output: 67
Script:
#!/bin/bash
# Search for door state handling in C# files
rg "unlit" --type cs -B2 -A2
# Look for door appearance system
ast-grep --pattern 'class $_ {
$$$
void UpdateAppearance($$$) {
$$$
}
}'
# Find door power-related components
rg "ApcPowerReceiver|PowerConsumer" --type yaml -A 3 | rg -B 3 "Door|Airlock"
Length of output: 14315
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/engineering.rsi/meta.json (3)
5-8: LGTM!
The sprite dimensions are correctly specified using the standard 32x32 pixel format.
165-177: Verify the long delay in sparks_damaged animation
The sparks_damaged state has an unusually long delay (1.7) at the end of its sequence compared to other spark animations. Please verify if this is intentional.
✅ Verification successful
The 1.7s delay in sparks_damaged animation is consistent across airlock variants
The verification shows that almost all airlock variants use the same animation timing pattern for sparks_damaged state: six quick 0.1s frames followed by a longer 1.7s frame. Only a few variants have slightly different patterns (6 frames instead of 7), suggesting this is an intentional and standardized animation timing across airlocks.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check if other damaged states in airlock RSIs have similar long delays
# Search for damaged state patterns in other airlock meta files
fd 'meta.json$' Resources/Textures/_White/Structures/Doors/Airlocks/ -x jq -r '.states[] | select(.name | contains("damaged")) | {name: .name, delays: .delays}'
Length of output: 4948
32-43: Verify animation timing consistency
The animation timing patterns for closing, opening, and panel_closing states use identical delay sequences. Consider extracting these common delay patterns into a shared configuration to ensure consistency and ease maintenance.
Also applies to: 78-90, 104-116
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/maint.rsi/meta.json (1)
9-203: Review animation timing patterns.
The animation states show some inconsistencies in timing patterns:
- Standard door animations (closing, opening) use: [0.1, 0.1, 0.07, 0.07, 0.07, 0.2]
- Emergency animations use: [0.4, 0.4]
- Static states like "assembly" have no animations
Consider:
- Standardizing the timing patterns for similar types of animations
- Adding assembly animation if the door has a visual assembly process
- Documenting the reasoning behind different timing patterns
✅ Verification successful
Animation timing patterns are consistent with established standards
The verification shows clear, intentional timing patterns across airlock animations:
- Standard doors (most airlocks): [0.1, 0.1, 0.07, 0.07, 0.07, 0.2]
- Emergency states: [0.4, 0.4]
- Sparks effects: [0.1, 0.1, 0.1, 0.1, 0.1, 0.1]
- Shuttle doors: [0.2, 0.2, 0.2, 0.2, 0.2, 0.2, 0.2, 0.2]
- External doors: [0.2, 0.2, 0.1, 0.1, 0.1, 0.3]
The maint.rsi file follows these established patterns correctly. Static states like "assembly" intentionally have no animations as they represent fixed states.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for consistency in animation timings across other airlock RSI files
# Find all airlock meta.json files
fd 'meta.json$' Resources/Textures/_White/Structures/Doors/Airlocks -x sh -c '
echo "=== Checking $1 ==="
# Extract and compare animation delays
jq -r ".states[] | select(.delays != null) | \"\(.name): \(.delays[0] | join(\", \"))\"" "$1"
' sh {}
Length of output: 25898
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/meta.json (3)
1-8: LGTM! Proper metadata and attribution.
The metadata section correctly includes version, license, and proper attribution to the original source with commit hash.
164-177: Verify the long delay in sparks_damaged animation.
The sparks_damaged state includes a notably long delay of 1.7 seconds at the end of its animation sequence. While this might be intentional for visual effect, please confirm if this timing aligns with the intended behavior.
#!/bin/bash
# Description: Check for similar timing patterns in other airlock definitions
# Search for sparks_damaged timing in other airlock files
fd -e json -p "Airlocks.*meta.json" | while read -r file; do
echo "=== Timing in $file ==="
jq -r '.states[] | select(.name == "sparks_damaged") | .delays' "$file"
echo
done9-202: Verify completeness of airlock states.
The animation states and timing patterns look consistent. However, let's verify that all required states are present by comparing with other airlock definitions.
✅ Verification successful
Let me generate another script to properly compare the states across airlock files, since the previous output only showed timing information:
All required airlock states are present and consistent
The medical airlock contains all the necessary states and matches exactly with other glass airlock variants (basic, engineering, science). The animation timing patterns are also consistent across all states:
- Door movement animations (opening/closing): 0.1, 0.1, 0.07, 0.07, 0.07, 0.2
- Sparks animations: 0.1 × 6 frames with 1.7s delay for damaged state
- Emergency state: 0.4, 0.4
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Compare states with other airlock definitions to ensure completeness
# Find all airlock meta.json files
fd -e json -p "Airlocks.*meta.json" | while read -r file; do
echo "=== States in $file ==="
jq -r '.states[].name' "$file" | sort
echo
done
Length of output: 36447
Script:
#!/bin/bash
# Find a reference airlock meta.json file and compare states with the medical airlock
echo "=== States in medical airlock ==="
jq -r '.states[].name' "Resources/Textures/_White/Structures/Doors/Airlocks/Glass/medical.rsi/meta.json" | sort
echo -e "\n=== States in other airlocks (sample) ==="
# Sample a few other airlock types for comparison
for file in Resources/Textures/_White/Structures/Doors/Airlocks/Glass/{basic,engineering,science}.rsi/meta.json; do
echo -e "\nStates in $(basename $(dirname $file)):"
jq -r '.states[].name' "$file" | sort
done
Length of output: 2728
Resources/Textures/_White/Structures/Doors/Airlocks/Glass/mining.rsi/meta.json (1)
3-4: Verify license compliance and attribution.
The file indicates it's derived from Paradise SS13's codebase. Please ensure:
- The modifications by the WD team are compatible with CC-BY-SA-3.0
- The original commit reference is still valid and accessible
Resources/Prototypes/Entities/Structures/Doors/Airlocks/shuttle.yml (3)
Line range hint 89-90: Verify intentional exclusion of glass airlock sprite updates
The sprite paths for glass airlocks (AirlockGlassShuttle and AirlockGlassShuttleSyndicate) were not updated with the "_White" prefix, unlike their non-glass counterparts. Please confirm if this is intentional or if these entities should also be updated for consistency.
#!/bin/bash
# Description: Check for patterns in glass vs non-glass airlock sprites
# Expected: Understand if there's a systematic difference in sprite organization
echo "Checking glass airlock sprite patterns..."
rg "sprite.*Glass.*shuttle" --type yamlAlso applies to: 143-144
32-32: Clarify relationship with PR objectives
The sprite path changes seem unrelated to the PR objectives of fixing power blinking and debug client crashes. Please clarify how these visual asset changes contribute to resolving those issues, or consider splitting these changes into a separate PR if they're unrelated.
#!/bin/bash
# Description: Search for related changes in power management code
# Expected: Find connections between sprite changes and power/debug fixes
echo "Searching for power-related changes..."
rg -l "power|battery|debug" --type yamlAlso applies to: 121-121, 168-168
32-32: Verify the existence of new sprite assets
The sprite paths have been updated to include a "_White" prefix. While the changes are consistent across the modified entities, we should verify that these new sprite assets exist in the specified locations.
Also applies to: 121-121, 168-168
✅ Verification successful
Sprite assets verified and found to be consistent
The verification shows that:
- The
_Whitedirectory exists in Resources/Textures - All required shuttle-related sprite assets are present in the new
_Whitepaths:Resources/Textures/_White/Structures/Doors/Airlocks/Standard/shuttle.rsiResources/Textures/_White/Structures/Doors/Airlocks/Glass/shuttle.rsiResources/Textures/_White/Structures/Doors/Airlocks/Standard/shuttle_syndicate.rsiResources/Textures/_White/Structures/Doors/Airlocks/Glass/shuttle_syndicate.rsi
The sprite path changes in the YAML files correctly reference these existing assets.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check if the new sprite assets exist
# Expected: All files should exist to prevent runtime errors
# Search for both old and new sprite paths to compare
echo "Searching for sprite files..."
fd -e rsi -e png "shuttle" "Resources/Textures/_White/Structures/Doors/Airlocks"
fd -e rsi -e png "shuttle" "Resources/Textures/Structures/Doors/Airlocks"
Length of output: 1147
Script:
#!/bin/bash
# Let's check for the existence of sprite files in both paths using a more comprehensive search
echo "Checking sprite paths in Resources/Textures..."
# List all files in the Textures directory that match the pattern
find Resources/Textures -type f -path "*Structures/Doors/Airlocks*shuttle*.rsi" -o -path "*_White/Structures/Doors/Airlocks*shuttle*.rsi"
# Also check if the _White directory exists
if [ -d "Resources/Textures/_White" ]; then
echo "_White directory exists"
else
echo "_White directory does not exist"
fi
# Let's also check for any references to these sprite paths in the codebase
echo -e "\nChecking sprite references in YAML files..."
rg "sprite:.*shuttle.*rsi" --type yaml
Length of output: 4065
Content.Server/Power/Pow3r/BatteryRampPegSolver.cs (2)
11-11: LGTM: Field declaration follows best practices
The new field is well-named and properly scoped.
13-15: LGTM: Constructor change maintains backward compatibility
The optional parameter addition is clean and preserves existing behavior by defaulting to false.
Let's verify that existing constructor calls won't be affected:
✅ Verification successful
Constructor change is safe and all existing usages are compatible
The verification shows that there are only two instances where BatteryRampPegSolver is instantiated:
Pow3r/Program.Simulation.cs: Uses default constructornew BatteryRampPegSolver()Content.Server/Power/EntitySystems/PowerNetSystem.cs: Uses default constructornew BatteryRampPegSolver()
Both usages are compatible with the new optional parameter as they use the default constructor without arguments, which will use the default value false.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for existing constructor calls to ensure compatibility
ast-grep --pattern 'new BatteryRampPegSolver($$$)'
Length of output: 123
Script:
#!/bin/bash
# Let's search for all references to BatteryRampPegSolver to ensure we catch all usages
rg "BatteryRampPegSolver" -A 2 -B 2
Length of output: 2277
Content.Server/Power/EntitySystems/PowerNetSystem.cs (3)
6-6: LGTM: Dependencies and imports are properly configured
The new dependencies for configuration management are correctly imported and injected.
Also applies to: 10-10, 23-23
30-30: Verify solver reinitialization impact
The removal of readonly modifier is necessary for runtime reconfiguration, but we should verify that solver reinitialization doesn't impact in-progress calculations.
✅ Verification successful
Solver reinitialization is safe
The solver is only used synchronously within the Tick method and there's no evidence of concurrent access or async operations. The field is properly encapsulated and the only usage is _solver.Tick() which is called in a controlled, sequential manner. The removal of readonly is safe in this context.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for any direct field access or concurrent usage of _solver
rg -l "(?<!_)solver\." --type cs
# Search for any async/parallel processing involving the solver
ast-grep --pattern 'async $_ $_($$$) {
$$$
$_solver
$$$
}'
Length of output: 320
Script:
#!/bin/bash
# Search for solver usage with proper regex
rg --pcre2 "(?<!_)solver\." --type cs
# Search for solver field access
rg "_solver\." --type cs -A 3
# Search for any async methods in PowerNetSystem
rg "async.*\{" "Content.Server/Power/EntitySystems/PowerNetSystem.cs" -A 5
# Look for parallel processing or Task usage with solver
rg "Task.*_solver" --type cs
rg "Parallel.*_solver" --type cs
Length of output: 796
37-37: Verify that disabling parallel processing resolves the reported issues
The changes provide the ability to disable parallel processing, but we should verify that this actually resolves the reported power blinking and debug client crashes.
Also applies to: 63-65
✅ Verification successful
Let me gather more specific information about the parallel processing implementation and any related issues.
Let me try a different approach to gather information about the power system and parallel processing implementation.
Based on the code analysis, I can now provide a final response:
Disabling parallel processing is a valid debugging option for power system issues
The implementation shows that:
- The power solver uses parallel processing for network computations by default
- The CVar
debug.pow3r_disable_parallelis specifically designed to help diagnose power-related issues - The BatteryRampPegSolver has proper handling for both parallel and serial execution modes
- The solver processes network layers sequentially, with parallel processing within each layer
The change is well-implemented and serves its intended purpose as a debugging tool for investigating power system issues.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for related crash reports or error patterns
rg -B 5 -A 5 "power.*blink|crash" --type log
# Look for any parallel processing related issues
rg -l "parallel|concurrent|race|deadlock|thread" --type cs
Length of output: 3348
Script:
#!/bin/bash
# Check the power solver implementation for parallel processing details
ast-grep --pattern 'class $_ : IPowerSolver {
$$$
}'
# Look for any power-related issues or discussions in commit messages
git log --grep="power.*blink\|parallel.*power" -i --pretty=format:"%h %s"
# Check the CVar definition for parallel processing
rg "DebugPow3rDisableParallel" -A 5 -B 5
Length of output: 56
Script:
#!/bin/bash
# Check the power solver interface and implementation
cat Content.Server/Power/Pow3r/IPowerSolver.cs
cat Content.Server/Power/Pow3r/BatteryRampPegSolver.cs
# Look for the CVar definition in a more specific way
cat Content.Shared/CCVar/CCVars.cs | rg -A 2 -B 2 "DebugPow3r"
# Check the PowerNetSystem for more context
cat Content.Server/Power/EntitySystems/PowerNetSystem.cs
Length of output: 36884
| "name": "panel_closing", | ||
| "delays": [ | ||
| [ | ||
| 0.1, | ||
| 0.1, | ||
| 0.07, | ||
| 0.07, | ||
| 0.07, | ||
| 0.07, | ||
| 0.27 | ||
| ] | ||
| ] | ||
| }, |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Inconsistent timing patterns in panel animations
The panel_closing and panel_opening animations have different timing patterns:
- closing: [0.1, 0.1, 0.07, 0.07, 0.07, 0.07, 0.27]
- opening: [0.2, 0.07, 0.07, 0.07, 0.07, 0.07, 0.2]
Consider standardizing these patterns for consistent behavior.
"delays": [
[
- 0.1,
- 0.1,
- 0.07,
- 0.07,
- 0.07,
- 0.07,
- 0.27
+ 0.2,
+ 0.07,
+ 0.07,
+ 0.07,
+ 0.07,
+ 0.07,
+ 0.2
]
]Also applies to: 133-145
| "name": "emergency_open_unlit", | ||
| "delays": [ | ||
| [ | ||
| 0.4, | ||
| 0.4 | ||
| ] | ||
| ] | ||
| }, |
There was a problem hiding this comment.
💡 Codebase verification
Emergency animation timing appears slower than other states
Looking at the animation timings in the same file:
- Emergency states use 0.4s delays (slowest)
- Regular door states use 0.2s delays
- Other animations use faster timings (0.1s, 0.07s)
The emergency animations are indeed slower than other states, which doesn't align with conveying urgency. Consider reducing the emergency animation delays to 0.1s or 0.07s to better represent the emergency nature of these states.
🔗 Analysis chain
Verify emergency animation timing
The emergency animations (emergency_open_unlit and emergency_unlit) use relatively slow 0.4s delays. Given this is an emergency state, consider if faster animations would be more appropriate for conveying urgency.
Also applies to: 153-160
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check if other emergency animations in the codebase use similar timing
# Test: Look for other emergency animation patterns
rg -g "*.json" -A 5 '"emergency.*".*"delays"'
Length of output: 141
Script:
#!/bin/bash
# Search for emergency animation patterns in JSON files, fixing the quote escaping
rg -g "*.json" -A 5 '"emergency.*".*"delays"' .
Length of output: 49
Script:
#!/bin/bash
# Search for any animation delays in the same directory to compare timings
find "$(dirname "Resources/Textures/_White/Structures/Doors/Airlocks/Glass/firelock.rsi/meta.json")" -name "meta.json" -exec sh -c 'echo "=== $1 ==="; cat "$1" | grep -A 5 "\"delays\"" || true' sh {} \;
Length of output: 1235
Script:
#!/bin/bash
# Look for other firelock-related animation timings
fd "firelock.*meta.json" . --exec grep -A 5 '"delays"' {} \;
Length of output: 65
| "states": [ | ||
| { | ||
| "name": "assembly" | ||
| }, | ||
| { | ||
| "name": "bolted_unlit" | ||
| }, | ||
| { | ||
| "name": "closed" | ||
| }, | ||
| { | ||
| "name": "closed_unlit" | ||
| }, | ||
| { | ||
| "name": "open_unlit" | ||
| }, | ||
| { | ||
| "name": "bolted_open_unlit" | ||
| }, | ||
| { | ||
| "name": "emergency_open_unlit" | ||
| }, |
There was a problem hiding this comment.
💡 Codebase verification
Missing several required airlock states
Based on comparison with other airlock RSIs in the codebase, the following states are missing:
closingandclosing_unlit- Door closing animation statesopeningandopening_unlit- Door opening animation statesdeny_unlit- Access denied indicatoropen- Basic open statepanel_closing,panel_open,panel_opening- Maintenance panel statessparks,sparks_broken,sparks_damaged,sparks_open- Damage indicator stateswelded- Welded shut state
These states are consistently present across nearly all other airlock RSIs and are required for proper airlock functionality.
🔗 Analysis chain
Verify completeness of basic airlock states.
While the basic states follow a clear naming convention, please verify that all necessary states are included.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for consistency of airlock states across similar RSI files
# Find all airlock RSI metadata files
fd -e json -p ".*Airlocks.*meta.json$" | while read -r file; do
echo "=== States in $file ==="
# Extract and sort state names for comparison
jq -r '.states[].name' "$file" | sort
done
Length of output: 49782
| "states": [ | ||
| { | ||
| "name": "assembly" | ||
| }, | ||
| { | ||
| "name": "bolted_unlit" | ||
| }, | ||
| { | ||
| "name": "closed" | ||
| }, | ||
| { | ||
| "name": "closed_unlit" | ||
| }, | ||
| { | ||
| "name": "open_unlit" | ||
| }, | ||
| { | ||
| "name": "bolted_open_unlit" | ||
| }, |
There was a problem hiding this comment.
💡 Codebase verification
Missing required static states in Glass/basic.rsi
Based on the comparison across all airlock RSI files, the following states are missing from the Glass/basic.rsi:
emergency_open_unlitpanel_openwelded
These states are commonly present in other airlock RSIs and are essential for proper airlock functionality.
🔗 Analysis chain
Verify completeness of static states.
The static states follow a consistent naming pattern and cover basic airlock conditions.
Let's verify if all required states are present by checking other airlock RSI files:
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Compare states across different airlock RSI files to ensure consistency
# Find all airlock meta.json files and compare their static states
# Find all airlock meta.json files
fd meta.json Resources/Textures/_White/Structures/Doors/Airlocks/
# Extract and compare static states (states without delays)
fd meta.json Resources/Textures/_White/Structures/Doors/Airlocks/ -x jq -r '.states[] | select(.delays == null) | .name' {} | sort | uniq -c
Length of output: 4003
| { | ||
| "name": "panel_closing", | ||
| "delays": [ | ||
| [ | ||
| 0.1, | ||
| 0.1, | ||
| 0.07, | ||
| 0.07, | ||
| 0.07, | ||
| 0.2 | ||
| ] | ||
| ] | ||
| }, | ||
| { | ||
| "name": "panel_open", | ||
| "delays": [ | ||
| [ | ||
| 1 | ||
| ] | ||
| ] | ||
| }, | ||
| { | ||
| "name": "panel_opening", | ||
| "delays": [ | ||
| [ | ||
| 0.1, | ||
| 0.1, | ||
| 0.07, | ||
| 0.07, | ||
| 0.07, | ||
| 0.2 | ||
| ] | ||
| ] | ||
| }, | ||
| { | ||
| "name": "sparks", | ||
| "delays": [ | ||
| [ | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 0.1 | ||
| ] | ||
| ] | ||
| }, | ||
| { | ||
| "name": "sparks_broken", | ||
| "delays": [ | ||
| [ | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 0.1 | ||
| ] | ||
| ] | ||
| }, | ||
| { | ||
| "name": "sparks_damaged", | ||
| "delays": [ | ||
| [ | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 1.7 | ||
| ] | ||
| ] | ||
| }, | ||
| { | ||
| "name": "sparks_open", | ||
| "delays": [ | ||
| [ | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 0.1, | ||
| 0.1 | ||
| ] | ||
| ] | ||
| }, | ||
| { | ||
| "name": "welded" | ||
| }, | ||
| { | ||
| "name": "emergency_unlit", | ||
| "delays": [ | ||
| [ | ||
| 0.4, | ||
| 0.4 | ||
| ] | ||
| ] | ||
| } | ||
| ] |
There was a problem hiding this comment.
💡 Codebase verification
Glass cargo airlock is missing required glass-specific states
The cargo glass airlock is missing several glass-specific states that are present in the standard glass airlock:
- assembly-fill
- assembly-glass
- closed-fill
- closed-glass
- closing-fill
- closing-glass
- closing-panel
- opening-fill
- opening-glass
- opening-panel
- panel_closed
These states are essential for proper glass airlock animations and functionality, as evidenced by their presence in the base glass.rsi template.
🔗 Analysis chain
Verify state completeness against other airlock types.
While the state coverage appears comprehensive, we should ensure consistency with other airlock types to maintain uniform behavior.
The previous command failed because the path pattern was incorrect. Let's first locate the actual paths of airlock meta.json files in the repository to understand the correct structure.
Now that we've found the correct paths, let's compare the states between different airlock types to verify consistency.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Compare state names across all airlock meta.json files
# Expected: All airlocks should have the same set of states
# Find all airlock meta.json files and extract state names for comparison
echo "Comparing state names across airlock types:"
fd meta.json -p "Resources/Textures.*Airlocks" --exec sh -c 'echo "=== $1 ==="; jq -r ".states[].name" "$1" | sort' sh {} \;
Length of output: 342
Script:
#!/bin/bash
# Let's try a different approach using ripgrep to find meta.json files
echo "Finding airlock meta.json files:"
rg --files | rg "Airlocks.*meta\.json$"
# Then let's examine one specific file to verify the path structure
echo -e "\nExamining file structure:"
find . -type f -name "meta.json" | grep -i "airlock"
Length of output: 13744
Script:
#!/bin/bash
# Let's compare states between a few representative airlock types
# We'll check basic, glass, and highsec variants to ensure consistency
echo "=== Basic Airlock States ==="
jq -r '.states[].name' "Resources/Textures/Structures/Doors/Airlocks/Standard/basic.rsi/meta.json" | sort
echo -e "\n=== Glass Airlock States ==="
jq -r '.states[].name' "Resources/Textures/Structures/Doors/Airlocks/Glass/glass.rsi/meta.json" | sort
echo -e "\n=== Highsec Airlock States ==="
jq -r '.states[].name' "Resources/Textures/Structures/Doors/Airlocks/highsec/highsec.rsi/meta.json" | sort
echo -e "\n=== Cargo Glass Airlock States (the one under review) ==="
jq -r '.states[].name' "Resources/Textures/Structures/Doors/Airlocks/Glass/cargo.rsi/meta.json" | sort
Length of output: 1935
| private void DebugPow3rDisableParallelChanged(bool val) | ||
| { | ||
| _solver = new(val); |
There was a problem hiding this comment.
Add thread safety and error handling to configuration change handler
The current implementation might be unsafe if the solver is being used when reconfiguration occurs. Consider adding thread synchronization and error handling.
- private void DebugPow3rDisableParallelChanged(bool val)
- {
- _solver = new(val);
- }
+ private readonly object _solverLock = new object();
+
+ private void DebugPow3rDisableParallelChanged(bool val)
+ {
+ try
+ {
+ lock (_solverLock)
+ {
+ _solver = new(val);
+ }
+ }
+ catch (Exception ex)
+ {
+ Logger.Error($"Failed to reconfigure solver: {ex}");
+ // Consider reverting the configuration value
+ _cfg.SetCVar(CCVars.DebugPow3rDisableParallel, !val);
+ }
+ }Also, ensure that the Update method uses the same lock:
public override void Update(float frameTime)
{
base.Update(frameTime);
ReconnectNetworks();
// Synchronize batteries
RaiseLocalEvent(new NetworkBatteryPreSync());
// Run power solver.
- _solver.Tick(frameTime, _powerState, _parMan);
+ lock (_solverLock)
+ {
+ _solver.Tick(frameTime, _powerState, _parMan);
+ }Committable suggestion skipped: line range outside the PR's diff.
|
блять какие шлюзы |
|
насрано. А еще это из апстрима поэтому смысла черрипикать с виздена нет смысла. |
From Add CVar to disable pow3r parallel processing
Fixes power blinking.
Fixes the debug client crashing after a certain period of time.