[Tweak] Secret / Секрет

[Spatison]

Описание PR

Изменены шансы выпадения режимов

Изменения

🆑 Spatison

• tweak: Changed the chances of modes falling out / Изменены шансы выпадения режимов

[coderabbitai]

Walkthrough

The pull request modifies the weights associated with various entities in the weightedRandom configuration for the Secret ID within the Resources/Prototypes/secret_weights.yml file. Specifically, it updates the weights for Survival and Extended, while the Traitor weight remains unchanged. The overall structure of the file is preserved, but the distribution of weights reflects the adjustments made.

Changes

File Path	Change Summary
Resources/Prototypes/secret_weights.yml	- Survival weight changed from 0.05 to 0.02
	- Extended weight changed from 0.04 to 0.07
	- Traitor weight remains unchanged at 0.45

Possibly related PRs

• [Tweak] Secret / Секрет #87: This PR modifies the weights in the same Resources/Prototypes/secret_weights.yml file, specifically adjusting the weights for "Survival" and "Extended," which are also addressed in the main PR.

Suggested labels

Changes: YML, Status: Needs Review

Suggested reviewers

• Remuchi

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

Resources/Prototypes/secret_weights.yml (1)

4-9: Probability distribution verified.

The adjusted weights maintain a valid probability distribution, summing to 1.0. However, these changes represent significant shifts in game mode frequencies:

• Extended mode: +75% increase (0.04 → 0.07)
• Survival mode: -60% decrease (0.05 → 0.02)

Consider adding comments to document the rationale behind these substantial probability adjustments for future reference.

- Extended: 0.07
+ Extended: 0.07  # Increased from 0.04 to provide more regular gameplay opportunities
  Traitor: 0.45
  Nukeops: 0.20
  Zombie: 0.10
  Revolutionary: 0.15
- Survival: 0.02
+ Survival: 0.02  # Reduced from 0.05 to make the mode more rare and special

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 7c4566f and c0c00aa.

📒 Files selected for processing (1)

• Resources/Prototypes/secret_weights.yml (1 hunks)

🔇 Additional comments (1)

Resources/Prototypes/secret_weights.yml (1)

4-11: Verify impact on game mode variety.

The significant reduction in Survival mode probability (0.02) makes it almost as rare as AllAtOnce (0.01). This could affect player expectations and gameplay variety.

Consider if this aligns with the intended player experience and game design goals. You might want to:

1. Gather player feedback on the current frequency of Survival mode
2. Monitor metrics after this change to ensure it achieves the desired effect
3. Consider a more moderate reduction if player feedback indicates Survival mode is highly valued