Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tweak] Pickaxe / Кирка #108

Merged
merged 3 commits into from
Nov 6, 2024
Merged

[Tweak] Pickaxe / Кирка #108

merged 3 commits into from
Nov 6, 2024

Conversation

Spatison
Copy link
Member

Описание PR

Кирка при тяжелом ударе теперь не тратит стамины, также скорость атаки и урон снижены


Изменения

🆑 Spatison

  • tweak: The pickaxe has been improved / Улучшена кирка

@Spatison Spatison requested a review from Remuchi October 29, 2024 10:05
@Spatison Spatison self-assigned this Oct 29, 2024
Copy link
Contributor

coderabbitai bot commented Oct 29, 2024

Walkthrough

The changes in this pull request involve updates to the pickaxe entity located in Resources/Prototypes/Entities/Objects/Weapons/Melee/pickaxe.yml. New properties related to heavy attacks have been added to the MeleeWeapon component, specifically heavyRateModifier, heavyDamageBaseModifier, and heavyStaminaCost. These modifications enhance the weapon's functionality by introducing parameters for heavy attack mechanics, while the overall structure of the pickaxe remains unchanged.

Changes

File Path Change Summary
Resources/Prototypes/Entities/Objects/Weapons/Melee/pickaxe.yml Added properties to MeleeWeapon: heavyRateModifier: 0.8, heavyDamageBaseModifier: 0.5, heavyStaminaCost: 0

Suggested reviewers

  • Remuchi

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 2373ad1 and f5090fa.

📒 Files selected for processing (1)
  • Resources/Prototypes/Entities/Objects/Weapons/Melee/pickaxe.yml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • Resources/Prototypes/Entities/Objects/Weapons/Melee/pickaxe.yml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (1)
Resources/Prototypes/Entities/Objects/Weapons/Melee/pickaxe.yml (1)

28-32: Consider adding explanatory comments for balance changes.

While the edit boundaries are clearly marked, it would be helpful to document the reasoning behind these specific values, especially since they differ significantly from the mining drill's configuration.

     # WD EDIT START
+    # Reduced heavy attack effectiveness but removed stamina cost
+    # - 20% slower heavy attacks
+    # - 50% reduced heavy attack damage
+    # - No stamina cost for accessibility
     heavyRateModifier: 1.2
     heavyDamageBaseModifier: 0.5
     heavyStaminaCost: 0
     # WD EDIT END
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 6093d72 and 2373ad1.

📒 Files selected for processing (1)
  • Resources/Prototypes/Entities/Objects/Weapons/Melee/pickaxe.yml (1 hunks)

@WWhiteDreamProject WWhiteDreamProject deleted a comment from coderabbitai bot Oct 31, 2024
@Remuchi
Copy link
Collaborator

Remuchi commented Oct 31, 2024

также скорость атаки и урон снижены

Так ты только увеличил ее. 1.2 увеличивает скорость атаки.

@Remuchi Remuchi merged commit b1a8861 into master Nov 6, 2024
9 of 10 checks passed
@Remuchi Remuchi deleted the pickaxe branch November 6, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants