[Feature] MedChem Sprite Update #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idk just random sprite update
WalkthroughThis pull request updates several Changes
Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
RSI Diff Bot; head commit ef00644 merging into d703498 Resources/Textures/Objects/Specific/Chemistry/beaker.rsi
Resources/Textures/Objects/Specific/Chemistry/beaker_bluespace.rsi
Resources/Textures/Objects/Specific/Chemistry/beaker_large.rsi
Resources/Textures/Objects/Specific/Chemistry/pills.rsi
Resources/Textures/Objects/Specific/Chemistry/pills_canister.rsi
Resources/Textures/Objects/Specific/Medical/firstaidkits.rsi
Resources/Textures/Objects/Specific/Mining/ore_bag_holding.rsi
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
Resources/Textures/Objects/Specific/Chemistry/pills.rsi/meta.json (1)
43-45: Consider reordering states for better maintainability.The new
pill22state is inserted betweenpill21andpill7, breaking the numerical sequence. Consider reordering the states to maintain a consistent numerical order.{ "name": "pill21" }, + { + "name": "pill7" + }, + { + "name": "pill8" + }, + { + "name": "pill9" + }, + { + "name": "pill10" + }, + { + "name": "pill11" + }, + { + "name": "pill12" + }, + { + "name": "pill13" + }, + { + "name": "pill14" + }, + { + "name": "pill15" + }, + { + "name": "pill16" + }, + { + "name": "pill17" + }, { "name": "pill22" }, - { - "name": "pill7" - }, - { - "name": "pill8" - }, - { - "name": "pill9" - }, - { - "name": "pill10" - }, - { - "name": "pill11" - }, - { - "name": "pill12" - }, - { - "name": "pill13" - }, - { - "name": "pill14" - }, - { - "name": "pill15" - }, - { - "name": "pill16" - }, - { - "name": "pill17" - },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (68)
Resources/Textures/Objects/Specific/Chemistry/beaker.rsi/beaker.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/beaker.rsi/beaker1.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/beaker.rsi/beaker2.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/beaker.rsi/beaker3.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/beaker.rsi/beaker4.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/beaker.rsi/beaker5.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/beaker.rsi/beaker6.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/beaker_bluespace.rsi/beakerbluespace.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/beaker_large.rsi/beakerlarge.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/beaker_large.rsi/beakerlarge1.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/beaker_large.rsi/beakerlarge2.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/beaker_large.rsi/beakerlarge3.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/beaker_large.rsi/beakerlarge4.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/beaker_large.rsi/beakerlarge5.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/beaker_large.rsi/beakerlarge6.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/pills.rsi/pill.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/pills.rsi/pill1.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/pills.rsi/pill10.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/pills.rsi/pill11.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/pills.rsi/pill12.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/pills.rsi/pill13.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/pills.rsi/pill14.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/pills.rsi/pill15.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/pills.rsi/pill16.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/pills.rsi/pill17.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/pills.rsi/pill18.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/pills.rsi/pill19.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/pills.rsi/pill2.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/pills.rsi/pill20.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/pills.rsi/pill21.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/pills.rsi/pill22.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/pills.rsi/pill3.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/pills.rsi/pill4.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/pills.rsi/pill5.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/pills.rsi/pill6.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/pills.rsi/pill7.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/pills.rsi/pill8.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/pills.rsi/pill9.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Chemistry/pills_canister.rsi/pill_canister.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/advkit-inhand-left.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/advkit-inhand-right.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/advkit.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/blackkit-inhand-left.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/blackkit-inhand-right.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/blackkit.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/brutekit-inhand-left.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/brutekit-inhand-right.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/brutekit.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/burnkit-inhand-left.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/burnkit-inhand-right.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/burnkit.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/firstaid-inhand-left.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/firstaid-inhand-right.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/firstaid.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/o2kit-inhand-left.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/o2kit-inhand-right.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/o2kit.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/purplekit-inhand-left.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/purplekit-inhand-right.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/purplekit.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/radkit-inhand-left.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/radkit-inhand-right.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/radkit.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/toxinkit-inhand-left.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/toxinkit-inhand-right.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Medical/firstaidkits.rsi/toxinkit.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Mining/ore_bag_holding.rsi/orebag_off.pngis excluded by!**/*.pngResources/Textures/Objects/Specific/Mining/ore_bag_holding.rsi/orebag_on.pngis excluded by!**/*.png
📒 Files selected for processing (7)
- Resources/Textures/Objects/Specific/Chemistry/beaker.rsi/meta.json (1 hunks)
- Resources/Textures/Objects/Specific/Chemistry/beaker_bluespace.rsi/meta.json (2 hunks)
- Resources/Textures/Objects/Specific/Chemistry/beaker_large.rsi/meta.json (1 hunks)
- Resources/Textures/Objects/Specific/Chemistry/pills.rsi/meta.json (2 hunks)
- Resources/Textures/Objects/Specific/Chemistry/pills_canister.rsi/meta.json (1 hunks)
- Resources/Textures/Objects/Specific/Medical/firstaidkits.rsi/meta.json (1 hunks)
- Resources/Textures/Objects/Specific/Mining/ore_bag_holding.rsi/meta.json (1 hunks)
✅ Files skipped from review due to trivial changes (5)
- Resources/Textures/Objects/Specific/Chemistry/beaker.rsi/meta.json
- Resources/Textures/Objects/Specific/Chemistry/beaker_large.rsi/meta.json
- Resources/Textures/Objects/Specific/Chemistry/pills_canister.rsi/meta.json
- Resources/Textures/Objects/Specific/Medical/firstaidkits.rsi/meta.json
- Resources/Textures/Objects/Specific/Mining/ore_bag_holding.rsi/meta.json
🔇 Additional comments (3)
Resources/Textures/Objects/Specific/Chemistry/beaker_bluespace.rsi/meta.json (2)
14-18: Review the significant animation slowdown.The animation timing has been increased from 0.2s (2 frames × 0.1s) to 2.5s (5 frames × 0.5s), which is a 12.5x slowdown. This might affect the visual feedback and user experience. Please confirm if this change is intentional and if it aligns with the game's visual design guidelines.
#!/bin/bash # Description: Check for consistency in animation timings across similar sprites # Expected: Find similar patterns in related chemical container sprites # Test: Search for animation timing patterns in other chemical RSI files fd -e json -p '**/Chemistry/*.rsi/meta.json' --exec rg -A 5 '"delays":'
4-4: Verify licensing compatibility with BlueMoon-Labs source.Please ensure that the assets from BlueMoon-Labs are compatible with the CC-BY-SA-3.0 license declared in this file. Consider adding the specific commit hash to the URL for better version tracking.
✅ Verification successful
License compatibility verified for BlueMoon-Labs assets
The assets are properly attributed with CC-BY-SA-3.0 license which is compatible with the repository's licensing structure. The repository uses AGPLv3 and MIT licenses for code, while art assets commonly use CC-BY-SA-3.0. Multiple files consistently reference the same BlueMoon-Labs source with proper attribution and licensing.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check if the source repository's license is compatible # Expected: Should find LICENSE or similar files in the BlueMoon repo # Test: Search for any license declarations in the source URL curl -s https://raw.githubusercontent.com/BlueMoon-Labs/MOLOT-BlueMoon-Station/master/LICENSELength of output: 381
Script:
#!/bin/bash # Let's check the license information in our repository first fd LICENSE --type f --exec head -n 20 {} # Also check for any license declarations in meta.json files fd meta.json --type f --exec rg -l "license|copyright" {} # And check the specific meta.json file content cat Resources/Textures/Objects/Specific/Chemistry/beaker_bluespace.rsi/meta.jsonLength of output: 271747
Script:
#!/bin/bash # Let's check the repository's license files and any license-related information # First, check the root LICENSE file cat LICENSE # Check if there are any other license files in the repository fd -g 'LICENSE*' -t f # Let's also check if there are any other files from BlueMoon-Labs being used rg -l "BlueMoon-Labs" --type jsonLength of output: 702
Script:
#!/bin/bash # Let's check the content of the AGPLv3 license and MIT license files cat LICENSE-AGPLv3.txt cat LICENSE-MIT.txt # Let's also check one of the other files using BlueMoon-Labs assets to see if they have consistent licensing cat Resources/Textures/Objects/Specific/Chemistry/beaker.rsi/meta.jsonLength of output: 36861
Resources/Textures/Objects/Specific/Chemistry/pills.rsi/meta.json (1)
4-4: Verify copyright attribution consistency.The copyright attribution references
tgstation, while the AI summary indicates other similar files in the Chemistry directory referenceBlueMoon-Labs. Please verify if this inconsistency is intentional.
|
Все прикольно кроме новой сумки утилизаторов. Не знаю она прямо очень странно выглядит. Кину ещё нашим спрайтерам посмотреть |
Remuchi
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание PR
Я хз, просто рандомная замена спрайтов.
Медиа
Содержание
Таблеточки в печати:
Все в сборе:
Все аптечки в сборе:
