Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include section on cleartext req/resp headers #1377

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Include section on cleartext req/resp headers #1377

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
816de49
Include section on cleartext req/resp headers
lusayaa Jan 7, 2025
35b7ab4
Specify outer vs inner http layers
lusayaa Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions FLEDGE_Key_Value_Server_API.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,20 @@ For more information on the design, please refer to [the trust model explainer](

![V2 API diagram](assets/fledge_kv_server_v2_api.png)

HTTPS is used to transport data. The method is `POST`.
The request contains an outer HTTP layer with an inner HTTP body that uses a repurposed [Oblivious HTTP](https://datatracker.ietf.org/doc/draft-ietf-ohai-ohttp/) encapsulation mechanism.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The request contains an outer HTTP layer with an inner HTTP body that uses a repurposed [Oblivious HTTP](https://datatracker.ietf.org/doc/draft-ietf-ohai-ohttp/) encapsulation mechanism.
The request contains an outer HTTP layer with an inner [Oblivious HTTP](https://datatracker.ietf.org/doc/draft-ietf-ohai-ohttp/) layer.


The HTTP POST body is encrypted.

### Outer HTTP layer
For the outer HTTP layer:
* HTTPS is used to transport data.
* The method is `POST`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The method is `POST`.
* The HTTP method is `POST`.

* Requests specify Content types via these headers:
```
Content-Type: message/ad-auction-trusted-signals-request
Accept: message/ad-auction-trusted-signals-response
```

### Inner HTTP layer

#### Encryption

Expand Down
Loading