Fetch key for B&A request #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: qingxinwu <[email protected]>
Co-authored-by: qingxinwu <[email protected]>
Co-authored-by: qingxinwu <[email protected]>
qingxinwu
reviewed
Sep 30, 2024
qingxinwu
reviewed
Oct 1, 2024
qingxinwu
reviewed
Oct 1, 2024
spec.bs
Outdated
| 1. Let |key| be a [=byte sequence=] containing one of the [[RFC9180|HPKE]] public | ||
| encryption keys for |config|'s [=auction data config/seller=] as determined | ||
| by |config|'s [=auction data config/coordinator=], or failure if no key is | ||
| 1. Let |key|,|key id| be a [=byte sequence=] containing one of the [[RFC9180|HPKE]] public |
There was a problem hiding this comment.
this seems broken. Key is a [=byte sequence=], not (|key|, |keyId|). Need to rewrite it a little bit
There was a problem hiding this comment.
Rephrased (pulled out to a function).
spec.bs
Outdated
| available. The actual method for this lookup is [=implementation-defined=], | ||
| and may consist of fetching the keys from a known [=URL=]. | ||
| 1. If |key| is failure then: | ||
| 1. [=Queue a global task=] on the [=DOM manipulation task source=], given |global|, to | ||
| [=reject=] |p| with a {{TypeError}}. | ||
| 1. Abort these steps. | ||
| 1. Set |config|'s [=auction data config/encryption key=] to |key|. | ||
| 1. Set |config|'s [=auction data config/encryption key id=] to |key id|. |
qingxinwu
reviewed
Oct 1, 2024
Co-authored-by: qingxinwu <[email protected]>
github-actions bot
added a commit
that referenced
this pull request
Oct 1, 2024
SHA: be2c7d5 Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
HabibiYou
pushed a commit
to HabibiYou/turtledove
that referenced
this pull request
Oct 29, 2024
* Add payload optimization * Add missing = * Add constraint on request size * Add key fetch * Move key lookup to parallel queue * Apply suggestions from code review Co-authored-by: qingxinwu <[email protected]> * Apply suggestions from code review Co-authored-by: qingxinwu <[email protected]> * Address comments * Address comments * Add domintro for AdAuctionDataConfig * Fix missing description * Apply suggestions from code review Co-authored-by: qingxinwu <[email protected]> * Describe values of {{AdAuctionDataConfig/perBuyerConfig}} * Fix filtering logic * rephrase * Address comments * rephrase and add key id * capitalize ID * rephrase * Apply suggestions from code review Co-authored-by: qingxinwu <[email protected]> --------- Co-authored-by: qingxinwu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff