[spec] Add Bidding and auction payload customization support #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morlovich
reviewed
Sep 9, 2024
morlovich
reviewed
Sep 11, 2024
qingxinwu
reviewed
Sep 24, 2024
Co-authored-by: qingxinwu <[email protected]>
qingxinwu
reviewed
Sep 24, 2024
qingxinwu
reviewed
Sep 25, 2024
qingxinwu
reviewed
Sep 27, 2024
Co-authored-by: qingxinwu <[email protected]>
qingxinwu
approved these changes
Sep 27, 2024
morlovich
reviewed
Sep 27, 2024
morlovich
reviewed
Sep 27, 2024
morlovich
approved these changes
Sep 27, 2024
github-actions bot
added a commit
that referenced
this pull request
Sep 30, 2024
SHA: 25ee9fd Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
5 tasks
HabibiYou
pushed a commit
to HabibiYou/turtledove
that referenced
this pull request
Oct 29, 2024
* Add payload optimization * Add missing = * Add constraint on request size * Apply suggestions from code review Co-authored-by: qingxinwu <[email protected]> * Address comments * Address comments * Add domintro for AdAuctionDataConfig * Fix missing description * Apply suggestions from code review Co-authored-by: qingxinwu <[email protected]> * Describe values of {{AdAuctionDataConfig/perBuyerConfig}} * Fix filtering logic --------- Co-authored-by: qingxinwu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff