[Spec] Add size API surface to joinAdInterestGroup #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtanzer
force-pushed
the
interestGroupSizes
branch
from
f992588
to
91e8789
Compare
added 15 commits
June 20, 2024 18:49
|
@domfarolino PTAL. @JensenPaul should officially add you as a reviewer soon. |
gtanzer
changed the title
|
Seems this will resolve issue #495 ? If so, please add reference to this issue in the description. |
dmdabbs
reviewed
Jun 28, 2024
qingxinwu
reviewed
Jun 28, 2024
Co-authored-by: qingxinwu <[email protected]>
Co-authored-by: qingxinwu <[email protected]>
Co-authored-by: qingxinwu <[email protected]>
domfarolino
reviewed
Jul 10, 2024
|
@domfarolino @qingxinwu All comments addressed. |
qingxinwu
approved these changes
Aug 13, 2024
qingxinwu
reviewed
Aug 19, 2024
Co-authored-by: qingxinwu <[email protected]>
qingxinwu
approved these changes
Aug 19, 2024
github-actions bot
added a commit
that referenced
this pull request
Aug 19, 2024
SHA: 8721b57 Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to qingxinwu/turtledove
that referenced
this pull request
Aug 20, 2024
SHA: 8721b57 Reason: push, by qingxinwu Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add size fields to the API surface for interest group joining / updating, and propagate those fields into interest group browser signals.
Note: Currently, the IDL fields sizeGroup in AuctionAd and width/height AuctionAdInterestGroupSize are specified to use USVString rather than DOMString, only because the Chromium implementation currently does. This contradicts the recommended use of DOMString for anything that won't appear in a UI. This issue is tracked at #1250
Preview | Diff