Set background attributionsrc request priority to low #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apasel422
commented
May 17, 2023
| @@ -2958,6 +2960,8 @@ and a [=header list=] |newHeaders| (defaults to an empty [=list=]): | |||
| :: "`no-store`" | |||
| 1. Return |request|. | |||
|
|
|||
| Issue: Should |request|'s [=request/priority=] be "`low`"? | |||
There was a problem hiding this comment.
@yoavweiss Could you comment on whether you think that report requests should also use low priority?
There was a problem hiding this comment.
@csharrison Any thoughts on this?
|
@lmck620 Please stop whatever process you are doing that involves crossposting all your comments in other repositories, to the Google Material Icons repository. I expect this is unintentional, but it is quite irksome for those of us on that repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #809
Preview | Diff