Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test workflows #68

Closed
wants to merge 1 commit into from
Closed

Conversation

H0R5E
Copy link
Contributor

@H0R5E H0R5E commented Sep 16, 2024

Test workflows are refactored to split out those triggered by WEC-Sim commits (wec-sim-***-tests) from those triggered by modifications to the applications (changed-tests).

This change is to try and help improve the distinction between the two types of testing workflows both by having distinct files and by using clearer language in the workflow titles and step names.

I also created another reusable workflow for the WEC-Sim triggered tests to avoid code duplication while maintaining distinct workflows and buttons.

Using this PR as a record of the thought process.

Test workflows are refactored to split out those triggered by WEC-Sim
commits (wec-sim-***-tests) from those triggered by modifications to the
applications (changed-tests).
@kmruehl kmruehl self-assigned this Sep 16, 2024
@kmruehl kmruehl added Tests/CI and removed wontfix labels Sep 16, 2024
@H0R5E
Copy link
Contributor Author

H0R5E commented Sep 16, 2024

I've tried to make some improvements since our discussion with @jtgrasb and @akeeste in order to try and make it a bit clearer what is going on. If you think this is OK, I'll merge and then apply directly to the dev branch.

@kmruehl
Copy link
Contributor

kmruehl commented Sep 16, 2024

@H0R5E can you submit this PR into dev? We're planning to tag v6.1 today, so dev will become main shortly. That way we don't have to pull this from main to dev too.

@H0R5E H0R5E changed the base branch from main to dev September 16, 2024 16:47
@H0R5E H0R5E changed the base branch from dev to main September 16, 2024 16:47
@H0R5E
Copy link
Contributor Author

H0R5E commented Sep 16, 2024

@H0R5E can you submit this PR into dev? We're planning to tag v6.1 today, so dev will become main shortly. That way we don't have to pull this from main to dev too.

Yep, I'll close this and do it directly.

@H0R5E H0R5E closed this Sep 16, 2024
@kmruehl
Copy link
Contributor

kmruehl commented Sep 16, 2024

I've tried to make some improvements since our discussion with @jtgrasb and @akeeste in order to try and make it a bit clearer what is going on. If you think this is OK, I'll merge and then apply directly to the dev branch.

Either way, it seems like we posted at basically the same time :)

@H0R5E H0R5E deleted the refactor_tests branch September 16, 2024 16:50
@H0R5E
Copy link
Contributor Author

H0R5E commented Sep 16, 2024

@kmruehl, I did both manually, because the badges wouldn't generate unless the workflows were on the main branch. Note that they are currently grey because these particular workflows won't have run until something happens in the WEC-Sim branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants