-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sdk with additional features #11
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please discuss the breaking changes as a proper changelog with Shariq.
cfg=cfg, | ||
seed=seed, | ||
neg_prompt=neg_prompt, | ||
high_res_results=int(high_res_results), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doc the conversion of boolean to int for usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving this change as it is as discussed
) | ||
|
||
status_code, content = self.__client.post( | ||
self.__endpoint, parameters, files=files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pick 1 convention and follow everywhere, other handlers have inline and unnamed params.
No description provided.