Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sdk with additional features #11

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Mauzis01
Copy link
Collaborator

No description provided.

@Mauzis01 Mauzis01 requested a review from m-shariq August 26, 2024 07:36
@Mauzis01 Mauzis01 self-assigned this Aug 26, 2024
Copy link

@bismapervaiz bismapervaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please discuss the breaking changes as a proper changelog with Shariq.

cfg=cfg,
seed=seed,
neg_prompt=neg_prompt,
high_res_results=int(high_res_results),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc the conversion of boolean to int for usage.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving this change as it is as discussed

)

status_code, content = self.__client.post(
self.__endpoint, parameters, files=files

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pick 1 convention and follow everywhere, other handlers have inline and unnamed params.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants