feat : added org hooks too

Vswaroop04 · Jul 12, 2024 · b352f91 · b352f91
1 parent 65eaf87
commit b352f91
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 17 deletions.
diff --git a/client/src/Components/Home.tsx b/client/src/Components/Home.tsx
@@ -82,7 +82,6 @@ export default function Home() {
                       currentToken
                     );
                     if (!repoSub.ok) {
-                      toast.error("Error Subscribing to Repo");
                       if (repoSub != "Webhook Created") {
                         setRepoSubscribeErrorMessage(repoSub.message);
                       }

diff --git a/server/src/controllers/webhook/createWebhook.ts b/server/src/controllers/webhook/createWebhook.ts
@@ -18,23 +18,27 @@ export const createWebHook = async (
 		if (!req.body.repository) {
 			return res.status(400).json({ message: 'Invalid request' });
 		}
-		const parts = req.body.repository.html_url.split('/');
-		const baseGithubUrl = parts.slice(0, 4).join('/');
-		const user = await getUserByGithubUrl(baseGithubUrl);
-		const repoName = extractRepoNameFromUrl(req.body.repository.html_url);
+		if (req.body.pull_request || req.body.pusher) {
+			const parts = req.body.repository.html_url.split('/');
+			const baseGithubUrl = parts.slice(0, 4).join('/');
+			const user = await getUserByGithubUrl(baseGithubUrl);
+			const repoName = extractRepoNameFromUrl(req.body.repository.html_url);
 
-		await sendPushNotification(
-			user.gcmToken,
-			req.body.action == 'opened'
-				? `${req.body.sender.login} created a new pull request in ${repoName}`
-				: `${req.body.pusher.name} added new commit in ${repoName}`,
-			req.body.action == 'opened'
-				? `Please take a look: A new pull request has been created in the repository ${repoName}. Click here to view: ${req.body.repository.html_url}`
-				: `New changes have been pushed to the repository ${repoName}. Click here to review: ${req.body.repository.html_url}`,
+			await sendPushNotification(
+				user.gcmToken,
+				req.body.action == 'opened'
+					? `${req.body.sender.login} created a new pull request in ${repoName}`
+					: `${req.body.pusher.name} added new commit in ${repoName}`,
+				req.body.action == 'opened'
+					? `Please take a look: A new pull request has been created in the repository ${repoName}. Click here to view: ${req.body.repository.html_url}`
+					: `New changes have been pushed to the repository ${repoName}. Click here to review: ${req.body.repository.html_url}`,
 
-			{ url: req.body.repository.html_url },
-		);
-		res.status(200).json({ message: 'Push Notification sent succesfully' });
+				{ url: req.body.repository.html_url },
+			);
+			res.status(200).json({ message: 'Push Notification sent succesfully' });
+		} else {
+			res.status(400).json({ message: 'Invalid request' });
+		}
 	} catch (error) {
 		if (error instanceof z.ZodError) {
 			res

diff --git a/server/src/services/github.ts b/server/src/services/github.ts
@@ -129,7 +129,7 @@ export const addWebhookForOrganizationRepo = async (
 ) => {
 	try {
 		const response = await fetch(
-			`https://api.github.com/repos/${organization}/${repo}/hooks`,
+			`https://api.github.com/orgs/${organization}/hooks`,
 			{
 				method: 'POST',
 				headers: {