Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi monitor related fixes #84

Merged
merged 7 commits into from
Feb 23, 2024

Conversation

ManpreetXSingh
Copy link
Contributor

@ManpreetXSingh ManpreetXSingh commented Feb 13, 2024

  • (Windows only) Removes the ability to hide the window behind the taskbar or other panels without affecting the ability to drag between monitors. New behavior:
GoZen_drag_constraints.mp4
  • Fixes an issue which occurs when the monitor, originally positioned at coordinates (0, 0), is moved, causing a corresponding offset in the window's position after dragging (or resizing) it. See attachment:
GoZen_multi_monitor_drag_bug_.mp4

Like behind the taskbar
Or behind the Copilot sidebar
when the coordinates of the main screen were changed and the window was dragged, the window would get a huge offset from where it should be.
This line did not get committed😅
@voylin
Copy link
Collaborator

voylin commented Feb 13, 2024

Looks good and would also work well on Linux normally. (Linux has many different desktop environments, but would be impossible to take them all into account :p)

@aappaapp
Copy link
Collaborator

I tested this on my Windows machine and it works :) good job

@voylin
Copy link
Collaborator

voylin commented Feb 20, 2024

When you feel that the PR is ready to be merged you can change it from draft to an actual PR ;)

@voylin voylin added this to the Version 1.0.0 milestone Feb 21, 2024
@ManpreetXSingh ManpreetXSingh marked this pull request as ready for review February 22, 2024 09:55
Copy link
Collaborator

@voylin voylin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work on this 😊

@voylin voylin merged commit 5c647b0 into VoylinsGamedevJourney:master Feb 23, 2024
1 check passed
@ManpreetXSingh ManpreetXSingh deleted the multi-monitor branch February 28, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants