Fix window maximize on windows #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a temporary fix for maximizing the window.
Earlier unless changed through code win_mode did not update to show the current window mode.
voylin
approved these changes
Feb 13, 2024
|
Looks good, thanks for the changes! ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a temporary fix for maximizing the window on windows. I've tested on Windows 11, Fedora KDE and OpenSUSE GNOME.
I've tried to keep the code as close to the original as possible. This should allow quick replacement of the code when the issue is fixed in godot itself.
There still exist slight issues like the windows 7 style title bar is displayed for 1 frame before the maximizing animation is played.
A major drawback of this fix is that
get_window().modedoes not returnWindow.MODE_MAXIMIZEDeven when the window is maximized. As a workaroundwin_modevariable is implemented with a getter and a setter.