Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Build on UE 5.0.3 #442

Merged
merged 3 commits into from
Oct 27, 2022
Merged

Conversation

guillaume-haerinck
Copy link
Contributor

I have heard that an update is coming, yet it was a fun exercise to do. I hope it will help some people who want to get started with the pluggin on UE5 in the meantime 😁

What does this PR do?

fix #441, fix #440, and maybe #439

Added the macro UE_5_CONVERT in VoxelEngineVersionHelpers.h to convert some data types to the API changes (it has a cost because we are making a new object on the stack, not casting).

Used the macro UE_5_SWITCH on several places to adapt to the API changes (when needed, used a check against VOXEL_ENGINE_VERSION). As some variables are now postfixed as DEPRECATED some places will need bigger revamps in the near future.

Hide minor textures in UE5 from the Voxel details panel as they are now missing.

sample

How was this PR tested?

Tested on UE 5.0.3 as well as UE 4.27.2 that build works. Looked for regression by using side-to-side engines (might have missed some bits as I'm a newbie user)

@Phyronnaz
Copy link
Collaborator

Thanks for the PR! We're indeed working on a big update internally so this won't apply to that, but I'll merge it into this repo so people can use it on 5 :)

@Phyronnaz Phyronnaz merged commit a1c5910 into VoxelPlugin:master Oct 27, 2022
@guillaume-haerinck guillaume-haerinck deleted the fix_ue5 branch October 27, 2022 20:20
Phyronnaz added a commit that referenced this pull request Jun 13, 2024
Fix Build on UE 5.0.3

Former-commit-id: c14b8c6cf4a314ae92618f34af3e1ec9c1b2c945 [formerly a1c5910]
Former-commit-id: 90c7e58d3efd60b3db2b33983e219a10605d3cc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

voxel for UE5.0.2?? Build Voxel Pro for UE5 Fails
2 participants