bugfix for lost x265 parameters #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when you select a parameter in x265 with a no- beginning, it was lost after opening the config window again
Vouk
requested changes
Mar 22, 2020
| @@ -123,7 +124,8 @@ void wxOptionEditor::Configure(EncoderInfo encoderInfo, OptionContainer options) | |||
|
|
|||
| // Import stored settings | |||
| //EncoderOptionInfo optionInfo = optionProperty->GetOptionInfo(); | |||
| if (options.find(optionInfo.parameter) != options.end()) | |||
| if (options.find(optionInfo.parameter) != options.end() | |||
There was a problem hiding this comment.
Nice finding!
- Make sure the combination "no-" + option name is actually a valid and supported option name. i.e. "no-preset" or "no-crf" is not supported
- This would match both "aq-motion" and "no-aq-motion". First one should set "Yes", second one "No". The latter case does work but only as part uncontrolled behaviour. "no-aq-motion" is not found in options[optionInfo.parameter]
- The whole "no-" thing should only be allowed for boolean option types
There was a problem hiding this comment.
In my tests this change worked fine so far without any bugs.
There was a problem hiding this comment.
I did another commit with an additional check if the prefix is valid. Only options where prependNoIfFalse is set to true in the json file are valid now.
One more check if the prependNoIfFalse boolean value is set to true, only if this is the case, is's a valid condition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.