Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure window still exists before getting document #396

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

p8
Copy link

@p8 p8 commented Nov 14, 2018

contentWindow might no longer exist resulting in errors like #44 and the error mentioned in #354

Uncaught TypeError: Cannot read property 'document' of null     wysihtml5x-toolbar-0.4.5.js:6712
getDocument                                                     wysihtml5x-toolbar-0.4.5.js:6712
wysihtml5.views.Composer.wysihtml5.views.View.extend._create    wysihtml5x-toolbar-0.4.5.js:11514
sandbox.dom.Sandbox.stylesheets                                 wysihtml5x-toolbar-0.4.5.js:11489
(anonymous function)                                            wysihtml5x-toolbar-0.4.5.js:6746

p8 added 2 commits November 14, 2018 20:31
Switching to view source and back again converts relative urls to
absolute urls even if we want relative urls.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant