Skip to content

Commit

Permalink
Merge pull request #257 from Vonage/dev
Browse files Browse the repository at this point in the history
Release 7.8.2
  • Loading branch information
superchilled authored Jan 4, 2023
2 parents 5dd438f + 1e33d4c commit 13a6810
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 23 deletions.
6 changes: 6 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# 7.8.2

* Updates the GSM::CHARACTERS constant to remove `ç` and instead add `Ç`. Fixes [#256](https://github.com/Vonage/vonage-ruby-sdk/issues/255)
* Updates code comments for `SMS#send` method to remove properties for unsupported message types `vCal`, `vCard`, and `wappush`
* Updates namespacing for referencing `SecurityUtils#secure_compare` method due to change in `ruby-jwt ` gem dependency.

# 7.8.1

* Changes JWT library dependency from `nexmo-jwt-ruby` to `conage-jwt-ruby`. See PR [#251](https://github.com/Vonage/vonage-ruby-sdk/pull/251)
Expand Down
2 changes: 1 addition & 1 deletion lib/vonage/gsm7.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module Vonage
module GSM7
extend T::Sig

CHARACTERS = "\n\f\r !\"\#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\\]^_abcdefghijklmnopqrstuvwxyz{|}~ ¡£¤¥§¿ÄÅÆÉÑÖØÜßàäåæçèéìñòöøùüΓΔΘΛΞΠΣΦΨΩ€"
CHARACTERS = "\n\f\r !\"\#$%&'()*+,-./0123456789:;<=>?@ABCDEFGHIJKLMNOPQRSTUVWXYZ[\\]^_abcdefghijklmnopqrstuvwxyz{|}~ ¡£¤¥§¿ÄÅÆÇÉÑÖØÜßàäåæèéìñòöøùüΓΔΘΛΞΠΣΦΨΩ€"

REGEXP = /\A[#{Regexp.escape(CHARACTERS)}]*\z/

Expand Down
2 changes: 1 addition & 1 deletion lib/vonage/signature.rb
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def check(params, signature_method: @config.signature_method)

signature = params.delete('sig')

::JWT::SecurityUtils.secure_compare(signature, digest(params, signature_method))
::JWT::Algos::Hmac::SecurityUtils.secure_compare(signature, digest(params, signature_method))
end

private
Expand Down
20 changes: 0 additions & 20 deletions lib/vonage/sms.rb
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,6 @@ class SMS < Namespace
# @option params [String] :type
# The format of the message body.
#
# @option params [String] :vcard
# A business card in [vCard format](https://en.wikipedia.org/wiki/VCard).
# Depends on **:type** option having the value `vcard`.
#
# @option params [String] :vcal
# A calendar event in [vCal format](https://en.wikipedia.org/wiki/VCal).
# Depends on **:type** option having the value `vcal`.
#
# @option params [String] :body
# Hex encoded binary data.
# Depends on **:type** option having the value `binary`.
Expand All @@ -67,18 +59,6 @@ class SMS < Namespace
# The value of the [protocol identifier](https://en.wikipedia.org/wiki/GSM_03.40#Protocol_Identifier) to use.
# Ensure that the value is aligned with **:udh**.
#
# @option params [String] :title
# The title for a wappush SMS.
# Depends on **:type** option having the value `wappush`.
#
# @option params [String] :url
# The URL of your website.
# Depends on **:type** option having the value `wappush`.
#
# @option params [String] :validity
# The availability for an SMS in milliseconds.
# Depends on **:type** option having the value `wappush`.
#
# @option params [String] :client_ref
# You can optionally include your own reference of up to 40 characters.
#
Expand Down
2 changes: 1 addition & 1 deletion lib/vonage/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# typed: strong

module Vonage
VERSION = '7.8.1'
VERSION = '7.8.2'
end

0 comments on commit 13a6810

Please sign in to comment.