Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect http method for updating users #953

Merged
merged 1 commit into from
Aug 22, 2024
Merged

fix: incorrect http method for updating users #953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/users/__tests__/__dataSets__/put.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ delete updateUser.id;
export default [
{
label: 'update user',
requests: [[`/v1/users/${testUser.id}`, 'PUT', updateUser]],
requests: [[`/v1/users/${testUser.id}`, 'PATCH', updateUser]],
responses: [
[
200,
Expand Down
2 changes: 1 addition & 1 deletion packages/users/lib/user.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ export class Users extends Client {
* @throws {Error} If there is an issue with the request or response, or if the user with the specified ID is not found.
*/
async updateUser(user: UserType): Promise<UserType> {
const resp = await this.sendPutRequest<UserResponse>(
const resp = await this.sendPatchRequest<UserResponse>(
`${this.config.apiHost}/v1/users/${user.id}`,
userToAPI(user),
);
Expand Down
Loading