Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicit_approval typeo in join type #870

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

muhammadzadeh
Copy link
Contributor

Description

The join type is fixed

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Merging #870 (285b728) into 3.x (65d4bcf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              3.x     #870   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files         121      121           
  Lines        1619     1619           
  Branches      311      311           
=======================================
  Hits         1358     1358           
  Misses        260      260           
  Partials        1        1           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@manchuck manchuck changed the title Bugfix, The join type renamed to explicit_approval fix: explicit_approval typeo in join type Oct 12, 2023
@manchuck manchuck merged commit 66ea103 into Vonage:3.x Oct 12, 2023
7 of 10 checks passed
@muhammadzadeh muhammadzadeh deleted the bugfix-join-type branch October 13, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants