Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(sms): Added incoming signature verification #861

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

dragonmantank
Copy link
Contributor

Description

Adds incoming signature verification to the SMS module. This adds a new verifySignature() method to the SMS module where the user can pass in the incoming signature, parameters to check, their signature secret, and the configured algorithm type.

Motivation and Context

Customer expectations dictated that we added this back into the SDKs. To avoid issues with JWT verification, this is added directly to the SMS API as it is the only one to use this verification technique.

Testing Details

Unit tests ported from the PHP testing suite.

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@manchuck manchuck merged commit 4b9aab7 into 3.x Aug 21, 2023
11 checks passed
@manchuck manchuck deleted the sms-signature-verification branch August 21, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants