fix(voice): Force NCCO actions to set value for NCCO type to avoid JS problems #853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When serializing an NCCO to a JS object, set the action to a static value instead of relying on the object's
this.action
property.Motivation and Context
When making the JS Object serializations, using
action: this.action
to generate the resulting objects would always result in a blank value. This seems to work fine on some versions of node, for the unit tests, and in TS, but when running in a pure JS environment the resulting value was blank. Since NCCOs have a static action value based on their type, this just sets the value directly during deserialization.Testing Details
Unit tests, as well as manual testing to help build the patch.
Example Output or Screenshots (if appropriate)
Types of changes
Checklist