Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: type for websocket header #851

Merged
merged 1 commit into from
Aug 9, 2023
Merged

fix: type for websocket header #851

merged 1 commit into from
Aug 9, 2023

Conversation

manchuck
Copy link
Contributor

@manchuck manchuck commented Aug 8, 2023

Fixes #833

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@manchuck manchuck marked this pull request as ready for review August 8, 2023 19:24
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2023

Codecov Report

Merging #851 (a551a80) into 3.x (f04c595) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              3.x     #851   +/-   ##
=======================================
  Coverage   83.42%   83.42%           
=======================================
  Files         119      119           
  Lines        1484     1484           
  Branches      283      283           
=======================================
  Hits         1238     1238           
  Misses        245      245           
  Partials        1        1           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@dragonmantank dragonmantank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manchuck manchuck merged commit 8dd49dd into 3.x Aug 9, 2023
14 checks passed
@manchuck manchuck deleted the fix-web-socket-type branch August 9, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebsocketEndpointObject incorrect type
3 participants