Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused libs #1258

Merged
merged 3 commits into from
Oct 31, 2022
Merged

Remove unused libs #1258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c02d248
Remove unused libs
ycanardeau Oct 31, 2022
c29d238
Replace $.extend with spread operator
ycanardeau Oct 31, 2022
4b18137
Uninstall bootstrap-sass
ycanardeau Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions VocaDbWeb/Scripts/Components/KnockoutExtensions/AlbumAutoComplete.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import {
} from '@/Components/KnockoutExtensions/EntryAutoComplete';
import { AlbumContract } from '@/DataContracts/Album/AlbumContract';
import { functions } from '@/Shared/GlobalFunctions';
import $ from 'jquery';
import React from 'react';
import { useTranslation } from 'react-i18next';

Expand Down Expand Up @@ -37,9 +36,8 @@ export const AlbumAutoComplete = ({
lang: vdb.values.languagePreference,
preferAccurateMatches: true,
maxResults: 15,
...properties.extraQueryParams,
};
if (properties.extraQueryParams)
$.extend(queryParams, properties.extraQueryParams);

const params: EntryAutoCompleteParams<AlbumContract> = {
acceptSelection: properties.acceptSelection!,
Expand Down
4 changes: 1 addition & 3 deletions VocaDbWeb/Scripts/Components/KnockoutExtensions/ArtistAutoComplete.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import {
import { ArtistContract } from '@/DataContracts/Artist/ArtistContract';
import { functions } from '@/Shared/GlobalFunctions';
import { ArtistSortRule } from '@/Stores/Search/ArtistSearchStore';
import $ from 'jquery';
import React from 'react';
import { useTranslation } from 'react-i18next';

Expand Down Expand Up @@ -40,9 +39,8 @@ export const ArtistAutoComplete = ({
preferAccurateMatches: true,
maxResults: 20,
sort: ArtistSortRule.ArtistType,
...properties.extraQueryParams,
};
if (properties.extraQueryParams)
$.extend(queryParams, properties.extraQueryParams);

const params: EntryAutoCompleteParams<ArtistContract> = {
acceptSelection: properties.acceptSelection!,
Expand Down
4 changes: 1 addition & 3 deletions VocaDbWeb/Scripts/Components/KnockoutExtensions/SongAutoComplete.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { NameMatchMode } from '@/Models/NameMatchMode';
import { SongQueryParams } from '@/Repositories/SongRepository';
import { functions } from '@/Shared/GlobalFunctions';
import { SongSortRule } from '@/Stores/Search/SongSearchStore';
import $ from 'jquery';
import React from 'react';
import { useTranslation } from 'react-i18next';

Expand Down Expand Up @@ -41,9 +40,8 @@ export const SongAutoComplete = ({
lang: vdb.values.languagePreference,
preferAccurateMatches: true,
sort: SongSortRule.SongType,
...properties.extraQueryParams,
};
if (properties.extraQueryParams)
$.extend(queryParams, properties.extraQueryParams);

return (
<EntryAutoComplete
Expand Down
15 changes: 0 additions & 15 deletions VocaDbWeb/Scripts/libs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,7 @@
window.$ = window.jQuery = require('jquery');

require('bootstrap-sass');

require('jquery-ui/accordion');
require('jquery-ui/autocomplete');
require('jquery-ui/button');
require('jquery-ui/datepicker');
require('jquery-ui/dialog');
require('jquery-ui/draggable');
require('jquery-ui/droppable');
require('jquery-ui/menu');
require('jquery-ui/mouse');
require('jquery-ui/progressbar');
require('jquery-ui/resizable');
require('jquery-ui/selectable');
require('jquery-ui/slider');
require('jquery-ui/sortable');
require('jquery-ui/spinner');
require('jquery-ui/tabs');

window.moment = require('moment');
11 changes: 0 additions & 11 deletions VocaDbWeb/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion VocaDbWeb/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@
"ajv": "^8.6.2",
"ajv-formats": "^2.1.1",
"axios": "^0.21.2",
"bootstrap-sass": "^2.3.2",
"classnames": "^2.3.1",
"decimal.js-light": "^2.5.1",
"highcharts": "^10.0.0",
Expand Down