Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a new event enum value, "Festival" #1199

Merged
merged 4 commits into from
Sep 1, 2022
Merged

Added a new event enum value, "Festival" #1199

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
16aaf14
added a new event enum value
kateabr Aug 16, 2022
177bb29
changed the namespace and added a test
kateabr Aug 17, 2022
3ac8855
test fix
kateabr Aug 17, 2022
c371126
test & typo fix
kateabr Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions VocaDbModel/Domain/ReleaseEvents/EventCategory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,9 @@ public enum EventCategory
/// </summary>
Convention = 1 << 5,
Other = 1 << 6,
/// <summary>
/// J-POP Cover Festival
/// </summary>
Festival = 1 << 7,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a unit test for the change? You can use one of the tests in the Tests/Domain folder (depending on whether or not numbers/names can be changed) as a reference. Additionally, can you please enable nullable reference types by removing the #nullable disable directive, and use the file-scoped namespace for this file? You can do this in a separate commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

}
}
1 change: 1 addition & 0 deletions VocaDbWeb/Scripts/Models/Events/EventCategory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@ export enum EventCategory {
Contest = 1 << 4,
Convention = 1 << 5,
Other = 1 << 6,
Festival = 1 << 7,
}
5 changes: 3 additions & 2 deletions VocaDbWeb/wwwroot/locales/en/VocaDb.Web.Resources.Domain.ReleaseEvents.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,9 @@
"Club": "Club",
"Concert": "Concert",
"Contest": "Contest",
"Convention": "Convention",
"Other": "Other",
"Festival": "Festival",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update not only json files, but also corresponding resx files on the VocaDB/vocadb-loc repo. These json files are intended to be automatically generated by this script (as part of #900). It would be nice if we could do this automatically at compile time though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added, VocaDB/vocadb-loc#2

"Convention": "Convention",
"Other": "Other",
"Unspecified": "Unspecified"
},
"EventSortRuleNames": {
Expand Down
1 change: 1 addition & 0 deletions VocaDbWeb/wwwroot/locales/ja/VocaDb.Web.Resources.Domain.ReleaseEvents.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"Club": "クラブ",
"Concert": "コンサート",
"Contest": "コンテスト",
"Festival": "祭り",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which should we use, "祭" or "祭り"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh that's a typo, I wanted to write "祭"

"Convention": "集会",
"Other": "その他",
"Unspecified": "カテゴリー無し"
Expand Down