Convert song edit to React #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 29, 2022
ycanardeau
force-pushed
the
react-song-edit
branch
from
6b17cda
to
05aa9a7
Compare
ycanardeau
force-pushed
the
react-song-edit
branch
from
05aa9a7
to
334764f
Compare
ycanardeau
commented
Jul 30, 2022
| <div className="editor-field"> | ||
| <ReleaseEventLockingAutoComplete | ||
| basicEntryLinkStore={songEditStore.releaseEvent} | ||
| // TODO: createNewItem="Create new event '{0}'" /* TODO: localize */ |
There was a problem hiding this comment.
TODO: VocaDbWeb/Scripts/Components/Song/SongEdit.tsx
// TODO: createNewItem="Create new event '{0}'" /* TODO: localize */
|
@Shiroizu This PR replaces See also #1133. |
|
These changes have been deployed to the main site, but let me know if you need to use Event Adder right now. I can revert the changes. |
|
@ycanardeau Thanks, I'll update the script. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.