Skip to content

Commit

Permalink
Fix handling for returned error added in f9100fb (grafana#3176)
Browse files Browse the repository at this point in the history
  • Loading branch information
gebn authored Nov 24, 2023
1 parent a0a0ce2 commit c00e7ef
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion tempodb/encoding/vparquet3/block_autocomplete.go
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ func createDistinctAttributeIterator(
if len(valueIters) > 0 || len(iters) > 0 {

if len(valueIters) > 0 {
tagIter := parquetquery.NewLeftJoinIterator(
tagIter, err := parquetquery.NewLeftJoinIterator(
definitionLevel,
[]parquetquery.Iterator{makeIter(keyPath, parquetquery.NewStringInPredicate(attrKeys), "key")},
valueIters,
Expand All @@ -389,6 +389,9 @@ func createDistinctAttributeIterator(
keep: keep,
},
)
if err != nil {
return nil, fmt.Errorf("creating left join iterator: %w", err)
}
iters = append(iters, tagIter)
}
return parquetquery.NewJoinIterator(
Expand Down

0 comments on commit c00e7ef

Please sign in to comment.