Fix: Refactored App.vue #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
May 11, 2023 14:15
BeierKevin
added
Phase: Construction
RUP: Implementation
improvement
|
For some arbitrary reason, after refactoring the token generation, the GitHub Actions CI can't find the crypto module. |
added 10 commits
May 12, 2023 10:00
added 2 commits
May 12, 2023 13:08
Claiyc
requested changes
May 12, 2023
6 tasks
|
tests failing? |
|
Indeed cuz of the node environment the test is done it cant find or use the package for clipboard on a node environment |
|
I made a simple workaround, because for some reason the node version of GitHub won't access the clipboard or something. |
Claiyc
requested changes
May 14, 2023
|
What should I change there ? |
I'd implement a loop here that generates ~10 tokens and checks for each of them if they meet all rules |
Claiyc
requested changes
May 15, 2023
Claiyc
reviewed
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Describe your changes in detail here
The App.vue file was way to large, it was hard to read and understand. To make it more clear what is happening for others to understand i extracted parts of it into other components to make it a lot easierer to understand and read.
Definition Of Done (DoD)
This PR can be squashed / merged if
Add additional conditions here if necessary for this PR
Fix: #160
Fix: #162