Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger #167

Open
6 tasks done
Claiyc opened this issue May 12, 2023 · 5 comments · May be fixed by #200
Open
6 tasks done

Logger #167

Claiyc opened this issue May 12, 2023 · 5 comments · May be fixed by #200

Comments

@Claiyc
Copy link
Member

Claiyc commented May 12, 2023

Issue description

Describe your issue in detail here
Implement a proper logger to replace console.log & console.error

Definition Of Ready (DoR)

This issue can be worked on if

  • a developer is assigned
  • the issue is labeled
  • the issue is assigned to the current sprint
  • the issue is estimated
  • a meaningful title has been set
  • the issue is described in detail
@Claiyc Claiyc converted this from a draft issue May 12, 2023
@Claiyc Claiyc moved this to Not Ready in Project VIGAD May 12, 2023
@Claiyc Claiyc mentioned this issue May 12, 2023
8 tasks
@Claiyc
Copy link
Member Author

Claiyc commented May 12, 2023

Having something like this would also be quite useful to trace issues like the tesseract workers crashing

@BeierKevin
Copy link
Contributor

We could build a simple logger ourself: https://adrianhall.github.io/cloud/2019/06/30/building-an-efficient-logger-in-typescript/

Or we maybe could use a library which will make things also easier: https://tslog.js.org/#/

@Claiyc
Copy link
Member Author

Claiyc commented May 13, 2023

I'd go with a dedicaed library

@Claiyc Claiyc moved this from Not Ready to Ready in Project VIGAD Jun 1, 2023
@roman533 roman533 self-assigned this Jun 1, 2023
@BeierKevin
Copy link
Contributor

BeierKevin commented Jun 1, 2023

When creating a composable for it stick to the current conventions.
For example it could be named: useLogger/useLogger.ts

and should be structured like this then

/**
 * Logger composable
 */
export default function useLogger() {
   ...

    return {
        ...
    };
}

@roman533 roman533 moved this from Ready to In progress in Project VIGAD Jun 5, 2023
@BeierKevin
Copy link
Contributor

Maybe documenting somewhere where you can find the log file ?

Image

@roman533 roman533 linked a pull request Jun 7, 2023 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

3 participants