[Improvement] Angle based killaura check #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update accounts for different platform types which can change the max angle a player can attack another entity at. This also should stop some false flags with Mobile players who are able to hit above the original 60 degrees.
|
Out of the box this won't work, but I see what you are trying to implement. I don't think it's a bad concept at all, but the values need to be investigated further. The values set for console and desktop appear to be way too low, and the value for mobile may be too high. I think 90 is achievable if POV is increased in your settings. Either way, testing and verification is required. |
|
As visual has said great concept just needs to be tested. |
|
Fortunately, I am able to run tests on Mobile, Desktop, and Console. Will just take time to analyze all three to fine tune each one. |
|
As you said, 90 can be achieved when increasing FOV on mobile, therefore I think it is reasonable to increase the FOV either way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update accounts for different platform types which can change the max angle a player can attack another entity at.
This also should stop some false flags with Mobile players who are able to hit above the original 60 degrees.