feat: added support for non-canonically DER encoded (counter)signatures #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds deferred parsing of SignedAttributes field of SignedInfo structure within CMS, allowing us to directly access the raw data of this field so that it can be properly verified without canonical DER decoder in the way. To make things easier and avoid rewrite of as many code as possible, there's option to turn `DeferSignerInfo` structure directly into `SignerInfo` structure. On top of that, all other fields are decoded as usual, making deferred structure still useful in cases where non-deferred attributes are needed. Affected binary added to tests.
metthal
force-pushed
the
modules/pe/deferred-der-decoding
branch
from
2c7bcec
to
2e5e6bf
Compare
metthal
changed the title
plusvic
approved these changes
Apr 22, 2024
plusvic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds deferred parsing of SignedAttributes field of SignedInfo structure within CMS, allowing us to directly access the raw data of this field so that it can be properly verified without canonical DER decoder in the way.
To make things easier and avoid rewrite of as many code as possible, there's option to turn
DeferSignerInfostructure directly intoSignerInfostructure. On top of that, all other fields are decoded as usual, making deferred structure still useful in cases where non-deferred attributes are needed.Affected binary added to tests.