Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issues in big-endian platforms #39

Merged
merged 7 commits into from
Aug 27, 2023
Merged

fix: issues in big-endian platforms #39

merged 7 commits into from
Aug 27, 2023

Commits on Aug 27, 2023

  1. chore: don't use the memx crate for slice comparison 

    The `memx` doesn't compile correctly in big-endian platforms. For the time being let's use the `==` operator for slice comparison. This change may be reconsidered later if the `==` operators proves to be too slow.
    @plusvic
    plusvic committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    d59ef05 View commit details
    Browse the repository at this point in the history

  2. fix: bug in big-endian platforms 

    When reading `i32` integers from WASM memory the integers must be swapped if we are in big-endian platforms because WASM stores the integers in little-endian format regardless of the host's endianness.
    @plusvic
    plusvic committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    2cbdaaa View commit details
    Browse the repository at this point in the history

  3. style: fix clippy warnings

    @plusvic
    plusvic committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    0a87acc View commit details
    Browse the repository at this point in the history

  4. chore: update Cargo.lock

    @plusvic
    plusvic committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    c5a2eef View commit details
    Browse the repository at this point in the history

  5. ci: run tests in big-endian platform s390x

    @plusvic
    plusvic committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    6562e3b View commit details
    Browse the repository at this point in the history

  6. ci: build in release mode 

    The debug build depends on `yara` for benchmarks, but this crate is not built correctly in the s390x platform.
    @plusvic
    plusvic committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    96dd54d View commit details
    Browse the repository at this point in the history

  7. ci: prevent GitHub workflows from running twice 

    When a commit is pushed to an open pull request the workflow will run twice: once for the push and once for the pull request, unless we specified that workflow for pull requests should run only when the pull request is opened or reopened.
    @plusvic
    plusvic committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    cac9472 View commit details
    Browse the repository at this point in the history