Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mach-o certificate parsing implemented #235

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

latonis
Copy link
Contributor

@latonis latonis commented Nov 3, 2024

With indygreg/cryptography-rs#21 being merged in now, we can have a much smaller dependency tree without reqwest and similar that were causing problems that caused the revert in 154994e for parsing certificates in mach-o binaries.

With not much progress for BER encoded certificates being made in RustCrypto/formats#779, I felt this was worth adding for the capability to search certificates in mach-o 😸

@plusvic
Copy link
Member

plusvic commented Nov 12, 2024

I still have concerns about introducing another set of dependencies that implement an ASN parser. Depending on different sets of crates that implement basically the same are far from ideal.

I don't recall which was the issue we were trying to solve here, but I think that in the der_parser crate we already have the tools needed for parsing BER encoded certificates, as long we implement the required ASN structures by ourselves.

@latonis
Copy link
Contributor Author

latonis commented Nov 12, 2024

I still have concerns about introducing another set of dependencies that implement an ASN parser. Depending on different sets of crates that implement basically the same are far from ideal.

I don't recall which was the issue we were trying to solve here, but I think that in the der_parser crate we already have the tools needed for parsing BER encoded certificates, as long we implement the required ASN structures by ourselves.

Yeah, that's a fair concern. I can take a look at using der_parser and implementing the needed parts myself. 😄

@latonis
Copy link
Contributor Author

latonis commented Nov 19, 2024

I'm working through the rewrite for this one :)

@latonis latonis marked this pull request as draft November 21, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants