rewritten to be a full macro to fix compiler issue #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prolativ can you please ack this? |
tgodzik
reviewed
Jul 26, 2024
| @@ -28,7 +28,7 @@ key3: | |||
|
|
|||
| (there is an [issue](YamlDecoder) with deriving YamlEncoder instance for Option datatype hence `YamlDecoder` instead `YamlCodec`) | |||
|
|
|||
| ```scala sc:compile | |||
There was a problem hiding this comment.
So this is no longer checked in the docs?
There was a problem hiding this comment.
No, can't be temporarily. Scaladoc has an issue with that.
There was a problem hiding this comment.
Ok, it seems it's just a scaladox issues. @lbialy please raise it upstream
tgodzik
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consulted with @jchyb, issue is more complex than just compiler issue. Best approach for now is to disable sc:compile for snippets that use derivation.