Fix parsing numbers #299
Merged
Fix parsing numbers #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use java.lang.Integer.decode which handles other radices besides 10 Also remove `_` from the number string
sideeffffect
commented
May 29, 2024
| Try(Integer.parseInt(value.drop(2), 8)).toEither.left | ||
| .map(t => ConstructError.from(t, "Int", node)) | ||
| else if (value.startsWith("0x")) | ||
| Try(Integer.parseInt(value.drop(2), 8)).toEither.left |
There was a problem hiding this comment.
8 instead of 16.
But it's better to leave it to Long.decode anyway.
tgodzik
reviewed
May 29, 2024
|
@tgodzik should be good now. Can you please run the CI workflow? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use java.lang.Integer.decode which handles other radices besides 10
Also remove
_from the number string