Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove cloudflare workers type from optional peer deps #347

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

sushichan044
Copy link
Member

Outline

peerDependenciesを緩める にあたって、自動更新が行われなくなることから
変に古い cloudflare workers の型定義を optional peer dependencies として要求する可能性がある

やったこと

cloudflare workers の型定義を peerDependencies から外して完全にユーザー側に任せる

Copy link

changeset-bot bot commented Dec 14, 2024

⚠️ No Changeset found

Latest commit: aeb5311

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the tsconfig Issues about tsconfig label Dec 14, 2024
Copy link

pkg-pr-new bot commented Dec 14, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@virtual-live-lab/tsconfig@347

commit: aeb5311

Copy link
Contributor

@kohsuke256 kohsuke256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

消したところで元から optional ですし消したところで問題には成りえなそう
ゆえによさそうであると判断しました

@sushichan044 sushichan044 merged commit cc7eb4e into main Dec 15, 2024
8 checks passed
@sushichan044 sushichan044 deleted the fix/remove-cf-from-peer branch December 15, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tsconfig Issues about tsconfig
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants