chore: loosened package restriction on Socket.IO #100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Urchin's package definition conflicted with Ephys Link in VBL docs because the range was too restrictive. When using
~=
, defining a patch number (like 5.8.0) restricts the packages to only 5.8.x versions instead of 5.x. Ephys Link is on 5.9.0.The better solution to this is to use dependabot which tracks security updates on packages and automatically opens PR's to update them. Ephys Link uses dependabot and then uses
==
version restriction to keep with exactly the version dependabot detects is safe.To enable, add
.github/dependabot.yml
with the following contentsYou can also add another clause for the NPM packages. In my fork of Urchin when I had enabled this it produced 2 security updates and discovered 5 security vulnerabilities (one of which was critical).