cleanup and use of pylint

.github/workflows/test.yml

@@ -27,11 +27,30 @@ jobs:
     - name: Install dependencies
       run: |
         python -m pip install --upgrade pip
-        python -m pip install flake8 mypy
+        python -m pip install flake8 mypy pylint
         if [ -f requirements.txt ]; then pip install -r requirements.txt; fi
     - name: Lint with flake8
       run: |
         flake8 ./tests/*.py ./logic/*.py --max-line-length=120
+    - name: Lint with pylint
+      run: |
+        pylint ./tests/*.py ./logic/*.py \
+         --max-line-length=120 \
+         --disable W1114 \
+         --disable C0103 \
+         --disable R0914 \
+         --disable R0911 \
+         --disable R0912 \
+         --disable R0915 \ 
+         --disable R0903
+    # W1114: arguments-out-of-order (pylint getting confused)
+    # C0103: invalid-name
+    # R0914: too-many-locals
+    # R0911: too-many-return-statements
+    # R0912: too-many-branches (preferably should not disable this)
+    # R0915: too-many-statements (preferably should not disable this)
+    # R0903: too-few-public-methods
+
     - name: Type checker with mypy
       run: |
         mypy ./tests/*.py ./logic/*.py

logic/__init__.py

@@ -1,4 +1,6 @@
-from .proof import Prover, Proof
-from .proposition import Proposition, IMPLY, IFF, AND, OR, NOT
+"""Logic is a predicate logic simulator and a automated prover"""
+
+from .proof import Proof, Prover
+from .proposition import AND, IFF, IMPLY, NOT, OR, Proposition
 
 __all__ = ["Proposition", "Proof", "Prover", "IMPLY", "IFF", "AND", "OR", "NOT"]